Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI and doc changes to address issues #9 and #4 #17

Merged
merged 7 commits into from Jun 16, 2021

Conversation

orionarcher
Copy link
Collaborator

@orionarcher orionarcher commented Jun 16, 2021

Description

This PR makes changes to the test_env.yaml and CI.yaml to support continuous integration.

Todos

From Issue #9

  • test_env.yaml to include the packages needed
  • Add fail-fast: false to the strategy section
  • Add concurrency groups

From Issue #4

  • fix docs requirement file to allow it to build
  • host updated docs at documentation website

Questions

  • Is anything else needed for CI to start working?

Status

  • Ready to go

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #17 (48649bd) into main (0324a5e) will decrease coverage by 29.53%.
The diff coverage is 22.72%.

@orionarcher
Copy link
Collaborator Author

orionarcher commented Jun 16, 2021

Looks like everything passed! The updated docs aren't yet hosted at readthedocs.org. Is there anything else that needs to be done to host them?

EDIT: I am realizing this will probably happen when this PR is merged

@orionarcher orionarcher changed the title Ci changes to address issue #9 CI and doc changes to address issues #9 and #4 Jun 16, 2021
Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Looks goods to me. The docs are building at https://solvation-analysis--17.org.readthedocs.build/en/17/ in the run tests so hopefully they appear when this is merged. I will squash and merge now.

@hmacdope hmacdope merged commit 818b4e4 into MDAnalysis:main Jun 16, 2021
@orionarcher orionarcher deleted the CI_changes branch August 16, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants