PR #2288 broke compiles

[joshStillerman]

The big PR #2288 seems to have broken builds using docker at least for ubuntu18 and ubuntu20.

The build: ../mdsplus/deploy/build.sh --os=ubuntu20 --release, chokes with:

gcc -Wall -Wextra -Werror   -g -O3 -fvisibility=hidden  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fpic -shared-libgcc -fsigned-char -fno-strict-aliasing  -DLIBPREFIX=Mds -pthread  -I/usr/include/libxml2 -I/home/jas/mdsplus/include -I/workspace/releasebld/64/include  -m64 -c -o UdpEvents.o /home/jas/mdsplus/mdsshr/UdpEvents.c
/home/jas/mdsplus/mdsshr/UdpEvents.c:39:10: fatal error: socket_port.h: No such file or directory
   39 | #include <socket_port.h>
      |          ^~~~~~~~~~~~~~~

this is because there is no -I/home/jas/mdsplus/_include in the command.

[zack-vii]

did you bootstrap?

[joshStillerman]

No -   I did not know it would be needed, since _include is not generated.  I will and see if it works.

On 6/9/21 9:35 AM, Timo Schroeder wrote: did you bootstrap? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#2320 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABY5AZM2X433QJTIBALNLSDTR5UZTANCNFSM46MAZXZA>.

-- *Joshua Stillerman* Research Engineer MIT Plasma Science and Fusion Center 617.253.8176 ***@***.*** ***@***.***>

[joshStillerman]

Bootstrap fixed it. Thanks.

[zack-vii]

That is true but the Makefiles are.

[joshStillerman]

I thought they were made by configure

[zack-vii]

you might be right but the templates used are generated from the m4/ files during bootstrap... i think ;)