Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #2288 broke compiles #2320

Closed
joshStillerman opened this issue Jun 9, 2021 · 6 comments
Closed

PR #2288 broke compiles #2320

joshStillerman opened this issue Jun 9, 2021 · 6 comments
Assignees
Labels
bug An unexpected problem or unintended behavior

Comments

@joshStillerman
Copy link
Contributor

The big PR #2288 seems to have broken builds using docker at least for ubuntu18 and ubuntu20.

The build: ../mdsplus/deploy/build.sh --os=ubuntu20 --release, chokes with:

gcc -Wall -Wextra -Werror   -g -O3 -fvisibility=hidden  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fpic -shared-libgcc -fsigned-char -fno-strict-aliasing  -DLIBPREFIX=Mds -pthread  -I/usr/include/libxml2 -I/home/jas/mdsplus/include -I/workspace/releasebld/64/include  -m64 -c -o UdpEvents.o /home/jas/mdsplus/mdsshr/UdpEvents.c
/home/jas/mdsplus/mdsshr/UdpEvents.c:39:10: fatal error: socket_port.h: No such file or directory
   39 | #include <socket_port.h>
      |          ^~~~~~~~~~~~~~~

this is because there is no -I/home/jas/mdsplus/_include in the command.

@joshStillerman joshStillerman added the bug An unexpected problem or unintended behavior label Jun 9, 2021
@zack-vii
Copy link
Contributor

zack-vii commented Jun 9, 2021

did you bootstrap?

@joshStillerman
Copy link
Contributor Author

joshStillerman commented Jun 9, 2021 via email

@joshStillerman
Copy link
Contributor Author

Bootstrap fixed it. Thanks.

@zack-vii
Copy link
Contributor

zack-vii commented Jun 9, 2021

That is true but the Makefiles are.

@joshStillerman
Copy link
Contributor Author

I thought they were made by configure

@zack-vii
Copy link
Contributor

zack-vii commented Jun 9, 2021

you might be right but the templates used are generated from the m4/ files during bootstrap... i think ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants