Feature: MdsIpThreadStatic ConnectionList; should fix deadlock and be faster #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the python connection test fails.. might be because the mdsip is a single connection server (-s) server |
zack-vii
force-pushed
the
zck-mdsip-dead-lock
branch
4 times, most recently
from
20a142a
to
f5da637
Compare
Merged
zack-vii
force-pushed
the
zck-mdsip-dead-lock
branch
from
f5da637
to
423265c
Compare
|
Let me know when this is ready for review |
|
well the mdsip cleanup one is first.. this is still in progress. i had it almost but then it was not possible to share one python Connection object between threads |
zack-vii
force-pushed
the
zck-mdsip-dead-lock
branch
20 times, most recently
from
7877167
to
e684a3d
Compare
zack-vii
force-pushed
the
zck-mdsip-dead-lock
branch
from
37fd5c1
to
e5ee2d1
Compare
WhoBrokeTheBuild
previously approved these changes
May 19, 2021
WhoBrokeTheBuild
approved these changes
May 19, 2021
MDSplusBuilder
pushed a commit
that referenced
this pull request
Jun 15, 2021
* tag 'alpha_release-7-131-1': (27 commits) Fix: Add extra selection for different trigger sources (#2314) Feature: MdsIpThreadStatic ConnectionList; should fix deadlock and be faster (#2288) Gm beans (#2312) Build: fixed alpine externals, removed python dependency if numpy is required Fix:jTraverer and jScope fixezs (#2310) Build: ub20 does not have python_numpy (#2309) Fix:changed event API (#2306) Build: debian cleanup repo Build: alpine fixed noarch Build: cleanup buildroot for debian Build: fixed Docker_NETWORK cleanup if not supported Build: network cannot be none for udp events Build: fixed build scripts to maintain multiarch files Build: isolate docker containers with --network=none Build: platform builds on empty/new release folder and format (#2304) Fix: Refactor out _MOVC3 macro (#2300) Tests: splits up python tests to get finer results (#2296) Build: fixed windows 32 to ship libgcc_s_dw2 as SEH is not supported for 32 bit yet (#2302) Fix:avoid division by zero foir empty segment (#2301) Tests: fixed fc32 helgrind suppression file ...
MDSplusBuilder
pushed a commit
that referenced
this pull request
Jun 15, 2021
* tag 'alpha_release-7-131-1': (27 commits) Fix: Add extra selection for different trigger sources (#2314) Feature: MdsIpThreadStatic ConnectionList; should fix deadlock and be faster (#2288) Gm beans (#2312) Build: fixed alpine externals, removed python dependency if numpy is required Fix:jTraverer and jScope fixezs (#2310) Build: ub20 does not have python_numpy (#2309) Fix:changed event API (#2306) Build: debian cleanup repo Build: alpine fixed noarch Build: cleanup buildroot for debian Build: fixed Docker_NETWORK cleanup if not supported Build: network cannot be none for udp events Build: fixed build scripts to maintain multiarch files Build: isolate docker containers with --network=none Build: platform builds on empty/new release folder and format (#2304) Fix: Refactor out _MOVC3 macro (#2300) Tests: splits up python tests to get finer results (#2296) Build: fixed windows 32 to ship libgcc_s_dw2 as SEH is not supported for 32 bit yet (#2302) Fix:avoid division by zero foir empty segment (#2301) Tests: fixed fc32 helgrind suppression file ...
MDSplusBuilder
pushed a commit
that referenced
this pull request
Jun 17, 2021
* tag 'alpha_release-7-131-1': (27 commits) Fix: Add extra selection for different trigger sources (#2314) Feature: MdsIpThreadStatic ConnectionList; should fix deadlock and be faster (#2288) Gm beans (#2312) Build: fixed alpine externals, removed python dependency if numpy is required Fix:jTraverer and jScope fixezs (#2310) Build: ub20 does not have python_numpy (#2309) Fix:changed event API (#2306) Build: debian cleanup repo Build: alpine fixed noarch Build: cleanup buildroot for debian Build: fixed Docker_NETWORK cleanup if not supported Build: network cannot be none for udp events Build: fixed build scripts to maintain multiarch files Build: isolate docker containers with --network=none Build: platform builds on empty/new release folder and format (#2304) Fix: Refactor out _MOVC3 macro (#2300) Tests: splits up python tests to get finer results (#2296) Build: fixed windows 32 to ship libgcc_s_dw2 as SEH is not supported for 32 bit yet (#2302) Fix:avoid division by zero foir empty segment (#2301) Tests: fixed fc32 helgrind suppression file ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MdsIpThreadStatic to ensure threads use their own connections: prevents race conditions on server and deadlocks