Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WorkflowSpecificationInformationType to align with ISA-950004 #48

Closed
vitalJP opened this issue Oct 10, 2019 · 3 comments
Closed

Comments

@vitalJP
Copy link

vitalJP commented Oct 10, 2019

Background
Explicitly Align B2MML with updated 950004 Workflow Specification Model by having "WorkflowSpecificationInformationType" address the 1st order objects used as master data.

Supporting Document
ISA950004
Clause 6.16.1 Workflow specification model, Figure 5 – Workflow specification model

Impacted Types and Solution
B2MML-WorkflowSpecification.xsd
complexType name = "WorkflowSpecificationInformationType"

CHANGE:

  • element name = "WorkflowSpecificationType" type = "WorkflowSpecificationTypeType"
    TO: "WorkflowSpecificationNodeType" type = "WorkflowSpecificationNodeTypeType"

ADD:

  • element name = "WorkflowSpecificationConnectionType" type = "WorkflowSpecificationConnectionTypeType" minOccurs = "0" maxOccurs = "unbounded"/>
@Dennis-Brandl
Copy link
Contributor

The proposed change does not match ISA 95 Part 4. The Node is just a step in a workflow, the WorkflowSpecificationInformation contains a set of WorkflowSpecifications, which contain nodes and connections.
The WorkflowSpecificaionType is missing the relationship to other IncludesThePropertiesOf
Not shown in ISA 95 Part 4 is a WorkflowSpecificationType, which NodeSpecifications and ConnectionSpecifications. This was added as the WorkflowSpecificationTypeType.

@JoeDo
Copy link
Member

JoeDo commented Feb 3, 2020

Confirmed the addition of an IncludesThePropertiesOf element in the January-2020-Sprint branch. I'll circle back and Close this issue after the changes have been merged into Master.

@Dennis-Brandl
Copy link
Contributor

Changed in the soon to be released version, Issue closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants