Update WorkflowSpecificationInformationType in WorkflowSpecification.xsd to align with updated 950004

[racheliurui]

MESAInternational/B2MML-BatchML#48

Background
Explicitly Align B2MML with updated 950004 Workflow Specification Model by having "WorkflowSpecificationInformationType" address the 1st order objects used as master data.

Supporting Document
ISA-950002 JWG5 CDV01 version (2019 12)
Clause 6.16.1 Workflow specification model, Figure 5 – Workflow specification model

Impacted Types and Solution
Related Issues: ##45, #46, #47, #48, #50
B2MML-WorkflowSpecification.xsd
complexType name = "WorkflowSpecificationInformationType"
CHANGE: element name = "WorkflowSpecificationType" type = "WorkflowSpecificationTypeType"
TO: "WorkflowSpecificationNodeType" type = "WorkflowSpecificationNodeTypeType"

ADD: element name = "WorkflowSpecificationConnectionType" type = "WorkflowSpecificationConnectionTypeType" minOccurs = "0" maxOccurs = "unbounded"/>

[racheliurui]

I disagree with this change.
WorkflowSpecificationInformationType for my understanding is to describe the workflow.
It would include overall information about the workflow.
Why does it need to include node type and connection type which is detailed information of the workflow specification internal definition?

[racheliurui]

Corrected my understanding.
WorkflowSpecificationInformation is used to publish WorkflowSpecificiation information or "JUST" node information or "Just" connection type information.
WorkflowSpecification is used to define a specific Workflow.

[CharlieG021163]

Original issue comment updated. Updated MESA Comment.

[CharlieG021163]

With Referenced Issues:
Background
Explicitly Align B2MML with updated 950004 Workflow Specification Model by having "WorkflowSpecificationInformationType" address the 1st order objects used as master data.

Supporting Document
ISA950004
Clause 6.16.1 Workflow specification model, Figure 5 – Workflow specification model

Impacted Types and Solution
B2MML-WorkflowSpecification.xsd
complexType name = "WorkflowSpecificationInformationType"

CHANGE:

#50 element name = "WorkflowSpecificationType" type = "WorkflowSpecificationTypeType"
TO: "WorkflowSpecificationNodeType" type = "WorkflowSpecificationNodeTypeType"
ADD:

element name = "WorkflowSpecificationConnectionType" type = "WorkflowSpecificationConnectionTypeType" minOccurs = "0" maxOccurs = "unbounded"/>

[vitalJP]

MESA version has been updated

[gerardmoloneyetpartners]

@CharlieG021163 @terryrankine
MESA feedback to review:
The proposed change does not match ISA 95 Part 4. The Node is just a step in a workflow, the WorkflowSpecificationInformation contains a set of WorkflowSpecifications, which contain nodes and connections.
The WorkflowSpecificaionType is missing the relationship to other IncludesThePropertiesOf
Not shown in ISA 95 Part 4 is a WorkflowSpecificationType, which NodeSpecifications and ConnectionSpecifications. This was added as the WorkflowSpecificationTypeType.

[Dennis-Brandl]

I agree with the change.

[gerardmoloneyetpartners]

Hi @Dennis-Brandl
Our issue in this github is slightly different to the issue in MESA github we submitted MESAInternational/B2MML-BatchML#48

I'll assess the diferences in

1. our MESA submission against this one in etp github
2. the fix on both (as yourself and JoeDo have applied a fix already.

I'll move this to 'commited by MESA' once reviewed.

[Dennis-Brandl]

So let me explain. I have been waiting for months to get a final V0700 released. I pulled the latest version from the b2mmlv7beta and after making some fixes (which I found running though XMLSpy) I committed these to the master branch in the measinternational. Any further requested changes should be raised as issues in the mesa international branch. There are only 5 issues in that branch, and one pull request. I had asked for comments on the proposed changes, and after over a month with no comments I felt we had to do something to move this forward. In the mesainternational branch, the comments are of the form: “the proposed change covers issue #35 <MESAInternational/B2MML-BatchML#35> ,#36 <MESAInternational/B2MML-BatchML#36> ,#37 <MESAInternational/B2MML-BatchML#37> ,#38 <MESAInternational/B2MML-BatchML#38> ,#42 <MESAInternational/B2MML-BatchML#42> ,#43 <MESAInternational/B2MML-BatchML#43> ,#44 <MESAInternational/B2MML-BatchML#44> " This is not helpful. If there is a problem, please document what the problem is so I don’t have to go searching through the versions to find it. I want to get this version out ASAP. Let’s not work at cross purposes. I will be in my office for the next several weeks, please let’s communicate by email, phone, or video to get this finished. At least we can close the 5 open issues. Dennis Dennis Brandl 208 Townsend Ct, Suite 200 Cary, NC 27518-8319, USA +1-919-852-5322 (Office) +1-919-656-2205 (Cell) +1-832-201-0554 (Fax) <http://www.brlconsulting.com/> www.brlconsulting.com <mailto:DnBrandl@BRLConsulting.com> DnBrandl@BRLConsulting.com From: gerardmoloneyetpartners <notifications@github.com> Sent: Monday, September 7, 2020 1:16 AM To: ETPartners/b2mmlv7beta <b2mmlv7beta@noreply.github.com> Cc: Dennis Brandl <dnbrandl@brlconsulting.com>; Mention <mention@noreply.github.com> Subject: Re: [ETPartners/b2mmlv7beta] Update WorkflowSpecificationInformationType in WorkflowSpecification.xsd to align with updated 950004 (#43) Hi @Dennis-Brandl <https://github.com/Dennis-Brandl> Our issue in this github is slightly different to the issue in MESA github we submitted MESAInternational/B2MML-BatchML#48 <MESAInternational/B2MML-BatchML#48> I'll assess the diferences in 1. our MESA submission against this one in etp github 2. the fix on both (as yourself and JoeDo have applied a fix already. I'll move this to 'commited by MESA' once reviewed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEBIXAQURABMICW26SXW4XDSERT7JANCNFSM4IQ6VVTQ> . <https://github.com/notifications/beacon/AEBIXARY3CQIJEPAXSXPXUDSERT7JA5CNFSM4IQ6VVT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFEBKX2Y.gif>