-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WorkflowSpecificationInformationType in WorkflowSpecification.xsd to align with updated 950004 #43
Comments
ERDi, MESA: complexType name = "WorkflowSpecificationInformationType"> CHANGE: - element name = "WorkflowSpecificationType" type = "WorkflowSpecificationTypeType" TO "WorkflowSpecificationNodeType" type = "WorkflowSpecificationNodeTypeType" ADD: - element name = "WorkflowSpecificationConnectionType" type = "WorkflowSpecificationConnectionTypeType" minOccurs = "0" maxOccurs = "unbounded"/> ERDi, MESA: complexType name = "WorkflowSpecificationType"> CHANGE: - element name = "Node" minOccurs = "0" maxOccurs = "unbounded"/> TO "WorkflowSpecificationNode" minOccurs = "1" maxOccurs = "unbounded"/> - element name = "Connection" TO "WorkflowSpecificationConnection" - element name = "WorkflowSpecificationProperty" type = "WorkflowPropertyType" TO "WorkflowSpecificationProperty" type = "WorkflowSpecificationPropertyType" - element name = "IncludesThePropertiesOf" TO "WorkflowSpecificationNodeParent" ADD: - element name = "DefinitionType", type = "DefinitionTypeType", minOccurs = "0"/> ERDi, MESA: complexType name = "WorkflowPropertyType", CHANGE: - complexType name = "WorkflowPropertyType" TO "WorkflowSpecificationPropertyType" - element name = "WorkflowProperty" TO "WorkflowSpecificationPropertyChild" DELETE: - element name = "EvaluatedPropertyReference" - element name = "TestResult" ERDI, MESA: DELETE complexType name = "WorkflowSpecificationTypeType", This is an intermediate type which simply refers to WorkflowSpecificationNodeTypeType and WorkflowSpecificationConnectionTypeType. It is simply not needed especially since these types are individually exchanged as first order objects as master data. Also, the name, WorkflowSpecificationType, is confusing since it implies that there is a type of Workflow Specification which there is not in the updated ISA-95 Part 2. ERDi, MESA: complexType name = "WorkflowSpecificationNodeType"> ADD: - element name = "Version", type = "VersionType" minOccurs = "0"/> - element name = "EffectiveFrom", type = "DateTimeType" minOccurs = "0" /> - element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" /> CHANGE: - element name = "NodeType" type = "IdentifierType" /> TO "WorkflowSpecificationNodeTypeID type = "IdentifierType" minOccurs = "0" maxOccurs = "1"/> - element name = "Property", type = "WorkflowSpecificationPropertyType" TO "WorkflowSpecifictionNodeProperty", type = "WorkflowSpecificationNodePropertyType" - element name = "IncludesThePropertiesOf" TO "WorkflowSpecificationNodeParent" ADD: - element name = "WorkMasterID", type = "IdentifierType" />, minOccurs = "0" maxOccurs = "unbounded"/> - element name = "WorkDirectiveID",type ="IdentifierType" />, minOccurs = "0" maxOccurs = "unbounded"/> ERDi, MESA: complexType name = "WorkflowSpecificationConnectionType"> CHANGE: - element name = "ConnectionType" type = "IdentifierType" /> TO "WorkflowSpecificationConnectionTypeID type = "IdentifierType" minOccurs = "0" maxOccurs = "1"/> - element name = "FromNodeID" TO "FromWSNodeID" - element name = "ToNodeID" TO "ToWSNodeID" - element name = "Property", type = "WorkflowSpecificationPropertyType" TO "WorkflowSpecifictionConnectionProperty", type = "WorkflowSpecificationConnectionPropertyType" ERDi, MESA: complexType name = "WorkflowSpecificationNodeTypeType" ADD: - element name = "Version", type = "VersionType" minOccurs = "0"/> - element name = "EffectiveFrom", type = "DateTimeType" minOccurs = "0" /> - element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" /> CHANGE: - element name = "Property", type = "WorkflowSpecificationPropertyType" TO "WorkflowSpecifictionNodeTypeProperty", type = "WorkflowSpecificationNodeTypePropertyType" ERDi, MESA: complexType name = "WorkflowSpecificationConnectionTypeType" ADD: - element name = "Version", type = "VersionType" minOccurs = "0"/> - element name = "EffectiveFrom", type = "DateTimeType" minOccurs = "0" /> - element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" /> CHANGE: - element name = "Property", type = "WorkflowSpecificationPropertyType" TO "WorkflowSpecifictionConnectionTypeProperty", type = "WorkflowSpecificationConnectionTypePropertyType"
I disagree with this change. |
Corrected my understanding. |
Original issue comment updated. Updated MESA Comment. |
With Referenced Issues: Supporting Document Impacted Types and Solution CHANGE: #50 element name = "WorkflowSpecificationType" type = "WorkflowSpecificationTypeType" element name = "WorkflowSpecificationConnectionType" type = "WorkflowSpecificationConnectionTypeType" minOccurs = "0" maxOccurs = "unbounded"/> |
MESA version has been updated |
@CharlieG021163 @terryrankine |
I agree with the change. |
Hi @Dennis-Brandl I'll assess the diferences in
I'll move this to 'commited by MESA' once reviewed. |
So let me explain. I have been waiting for months to get a final V0700 released. I pulled the latest version from the b2mmlv7beta and after making some fixes (which I found running though XMLSpy) I committed these to the master branch in the measinternational.
Any further requested changes should be raised as issues in the mesa international branch. There are only 5 issues in that branch, and one pull request.
I had asked for comments on the proposed changes, and after over a month with no comments I felt we had to do something to move this forward.
In the mesainternational branch, the comments are of the form: “the proposed change covers issue #35 <MESAInternational/B2MML-BatchML#35> ,#36 <MESAInternational/B2MML-BatchML#36> ,#37 <MESAInternational/B2MML-BatchML#37> ,#38 <MESAInternational/B2MML-BatchML#38> ,#42 <MESAInternational/B2MML-BatchML#42> ,#43 <MESAInternational/B2MML-BatchML#43> ,#44 <MESAInternational/B2MML-BatchML#44> " This is not helpful. If there is a problem, please document what the problem is so I don’t have to go searching through the versions to find it. I want to get this version out ASAP. Let’s not work at cross purposes.
I will be in my office for the next several weeks, please let’s communicate by email, phone, or video to get this finished. At least we can close the 5 open issues.
Dennis
Dennis Brandl
208 Townsend Ct, Suite 200
Cary, NC 27518-8319, USA
+1-919-852-5322 (Office)
+1-919-656-2205 (Cell)
+1-832-201-0554 (Fax)
<http://www.brlconsulting.com/> www.brlconsulting.com
<mailto:DnBrandl@BRLConsulting.com> DnBrandl@BRLConsulting.com
From: gerardmoloneyetpartners <notifications@github.com>
Sent: Monday, September 7, 2020 1:16 AM
To: ETPartners/b2mmlv7beta <b2mmlv7beta@noreply.github.com>
Cc: Dennis Brandl <dnbrandl@brlconsulting.com>; Mention <mention@noreply.github.com>
Subject: Re: [ETPartners/b2mmlv7beta] Update WorkflowSpecificationInformationType in WorkflowSpecification.xsd to align with updated 950004 (#43)
Hi @Dennis-Brandl <https://github.com/Dennis-Brandl>
Our issue in this github is slightly different to the issue in MESA github we submitted MESAInternational/B2MML-BatchML#48 <MESAInternational/B2MML-BatchML#48>
I'll assess the diferences in
1. our MESA submission against this one in etp github
2. the fix on both (as yourself and JoeDo have applied a fix already.
I'll move this to 'commited by MESA' once reviewed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#43 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEBIXAQURABMICW26SXW4XDSERT7JANCNFSM4IQ6VVTQ> . <https://github.com/notifications/beacon/AEBIXARY3CQIJEPAXSXPXUDSERT7JA5CNFSM4IQ6VVT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFEBKX2Y.gif>
|
MESAInternational/B2MML-BatchML#48
Background
Explicitly Align B2MML with updated 950004 Workflow Specification Model by having "WorkflowSpecificationInformationType" address the 1st order objects used as master data.
Supporting Document
ISA-950002 JWG5 CDV01 version (2019 12)
Clause 6.16.1 Workflow specification model, Figure 5 – Workflow specification model
Impacted Types and Solution
Related Issues: ##45, #46, #47, #48, #50
B2MML-WorkflowSpecification.xsd
complexType name = "WorkflowSpecificationInformationType"
CHANGE: element name = "WorkflowSpecificationType" type = "WorkflowSpecificationTypeType"
TO: "WorkflowSpecificationNodeType" type = "WorkflowSpecificationNodeTypeType"
ADD: element name = "WorkflowSpecificationConnectionType" type = "WorkflowSpecificationConnectionTypeType" minOccurs = "0" maxOccurs = "unbounded"/>
The text was updated successfully, but these errors were encountered: