Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide aerosol data via pooch #267

Merged
merged 5 commits into from Jul 12, 2023

Conversation

mathause
Copy link
Member

@mathause mathause commented Jul 11, 2023

This has mesmer download and cache the aerosol data using pooch. I went for pooch because I have a bit of experience with it from regionmask. I think this approach should be fine, certainly as long as we stay in the MB range. pooch is added as additional dependency (however, regionmask also has pooch in its list of requirements so it's not really adding anything).

I expect the tests to fail because the data file is currently not yet available at the specified location on github. Maybe I do another PR for this.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 88.23% and project coverage change: +0.24 🎉

Comparison is base (de55522) 85.87% compared to head (dfd6156) 86.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   85.87%   86.11%   +0.24%     
==========================================
  Files          38       39       +1     
  Lines        1515     1527      +12     
==========================================
+ Hits         1301     1315      +14     
+ Misses        214      212       -2     
Flag Coverage Δ
unittests 86.11% <88.23%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mesmer/calibrate_mesmer/train_gt.py 91.46% <80.00%> (-1.04%) ⬇️
mesmer/io/load_obs.py 32.07% <83.33%> (+3.50%) ⬆️
mesmer/core/_data.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mathause
Copy link
Member Author

This now passes! Depending on #269 this should allow to remove cfg.obs_dir.

@mathause
Copy link
Member Author

pinging @znicholls if you are interested to take a look

@znicholls
Copy link
Collaborator

Nice

@mathause mathause merged commit 80ac9d5 into MESMER-group:main Jul 12, 2023
7 checks passed
@mathause mathause deleted the aerosol_data_via_pooch branch July 12, 2023 12:23
@mathause
Copy link
Member Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants