New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide aerosol data via pooch #267
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 85.87% 86.11% +0.24%
==========================================
Files 38 39 +1
Lines 1515 1527 +12
==========================================
+ Hits 1301 1315 +14
+ Misses 214 212 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This now passes! Depending on #269 this should allow to remove |
pinging @znicholls if you are interested to take a look |
Nice |
thanks! |
isort . && black . && flake8
CHANGELOG.rst
This has mesmer download and cache the aerosol data using pooch. I went for pooch because I have a bit of experience with it from regionmask. I think this approach should be fine, certainly as long as we stay in the MB range. pooch is added as additional dependency (however, regionmask also has pooch in its list of requirements so it's not really adding anything).
I expect the tests to fail because the data file is currently not yet available at the specified location on github. Maybe I do another PR for this.