Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to observations_root_dir (dir_obs) #324

Merged
merged 1 commit into from Nov 2, 2023

Conversation

mathause
Copy link
Member

@mathause mathause commented Nov 2, 2023

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

Another minor cleanup (after #267)

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1711b8) 87.57% compared to head (df7f45b) 87.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   87.57%   87.56%   -0.01%     
==========================================
  Files          38       38              
  Lines        1674     1673       -1     
==========================================
- Hits         1466     1465       -1     
  Misses        208      208              
Flag Coverage Δ
unittests 87.56% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mesmer/calibrate_mesmer/calibrate_mesmer.py 92.50% <ø> (-0.07%) ⬇️
mesmer/calibrate_mesmer/train_gt.py 91.54% <ø> (ø)
mesmer/calibrate_mesmer/train_gv.py 95.00% <ø> (ø)
mesmer/calibrate_mesmer/train_lt.py 88.23% <ø> (ø)
mesmer/calibrate_mesmer/train_lv.py 84.33% <ø> (ø)
mesmer/core/computation.py 100.00% <100.00%> (ø)
mesmer/core/grid.py 97.82% <ø> (ø)
mesmer/core/utils.py 100.00% <100.00%> (ø)
mesmer/core/weighted.py 100.00% <ø> (ø)
mesmer/create_emulations/create_emus_gv.py 89.18% <ø> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause merged commit 3c2be6a into MESMER-group:main Nov 2, 2023
7 checks passed
@mathause mathause deleted the remove_dir_obs branch November 2, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant