Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove references to observations_root_dir (dir_obs) #324

Merged
merged 1 commit into from Nov 2, 2023
Merged

remove references to observations_root_dir (dir_obs) #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/config_tas_cmip6ng_example.py
View file
Open in desktop
Expand Up @@ -26,9 +26,6 @@
# cmip-ng
dir_cmipng = os.path.join(TEST_DATA_ROOT, f"cmip{gen}-ng")

# observations
dir_obs = os.path.join(TEST_DATA_ROOT, "observations")

# mesmer output
dir_aux = os.path.join(EXAMPLE_OUTPUT_ROOT, "auxiliary")
dir_mesmer_params = os.path.join(EXAMPLE_OUTPUT_ROOT, "calibrated_parameters")
Expand Down
4 changes: 0 additions & 4 deletions mesmer/calibrate_mesmer/calibrate_mesmer.py
View file
Open in desktop
Expand Up @@ -27,7 +27,6 @@ def __init__(
scenarios,
cmip_generation,
cmip_data_root_dir,
observations_root_dir,
auxiliary_data_dir,
reference_period_type,
reference_period_start_year,
Expand Down Expand Up @@ -58,7 +57,6 @@ def __init__(
self.gen = cmip_generation

self.dir_cmipng = cmip_data_root_dir
self.dir_obs = observations_root_dir
self.dir_aux = auxiliary_data_dir
self.ref = {
"type": reference_period_type,
Expand Down Expand Up @@ -122,7 +120,6 @@ def _calibrate_tas(
threshold_land,
output_file,
cmip_data_root_dir=None,
observations_root_dir=None,
auxiliary_data_dir=None,
cmip_generation=6,
reference_period_type="individ",
Expand Down Expand Up @@ -164,7 +161,6 @@ def _calibrate_tas(
scenarios=scenarios_to_train,
cmip_generation=cmip_generation,
cmip_data_root_dir=cmip_data_root_dir,
observations_root_dir=observations_root_dir,
auxiliary_data_dir=auxiliary_data_dir,
reference_period_type=reference_period_type,
reference_period_start_year=reference_period_start_year,
Expand Down
6 changes: 0 additions & 6 deletions tests/integration/test_calibrate_mesmer.py
View file
Open in desktop
Expand Up @@ -96,11 +96,6 @@ def test_calibrate_mesmer(
"calibrate-coarse-grid",
f"cmip{test_cmip_generation}-ng",
)
test_observations_root_dir = os.path.join(
test_data_root_dir,
"calibrate-coarse-grid",
"observations",
)
test_auxiliary_data_dir = os.path.join(
test_data_root_dir,
"calibrate-coarse-grid",
Expand All @@ -114,7 +109,6 @@ def test_calibrate_mesmer(
output_file=test_output_file,
cmip_data_root_dir=test_cmip_data_root_dir,
cmip_generation=test_cmip_generation,
observations_root_dir=test_observations_root_dir,
auxiliary_data_dir=test_auxiliary_data_dir,
use_tas2=use_tas2,
use_hfds=use_hfds,
Expand Down