Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start testing min required dependencies #398

Merged
merged 13 commits into from Feb 27, 2024

Conversation

mathause
Copy link
Member

Start testing the lowest version of our supported dependencies. We don't specify the all of them as of yet. But with #396 and #397 this becomes relevant.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.95%. Comparing base (9b0b76b) to head (3b31f76).
Report is 7 commits behind head on main.

❗ Current head 3b31f76 differs from pull request most recent head b30d795. Consider uploading reports for the commit b30d795 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   87.90%   87.95%   +0.04%     
==========================================
  Files          40       40              
  Lines        1745     1743       -2     
==========================================
- Hits         1534     1533       -1     
+ Misses        211      210       -1     
Flag Coverage Δ
unittests 87.95% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause
Copy link
Member Author

Actually version 0.9 of regionmask was required even before (for the new code path)...

@mathause mathause mentioned this pull request Feb 16, 2024
4 tasks
@mathause mathause marked this pull request as draft February 16, 2024 10:52
@mathause mathause marked this pull request as ready for review February 16, 2024 13:01
@mathause
Copy link
Member Author

Gentle ping @veni-vidi-vici-dormivi

environment.yml Outdated Show resolved Hide resolved
.github/workflows/ci-additional.yml Outdated Show resolved Hide resolved
@mathause mathause merged commit 87779a1 into MESMER-group:main Feb 27, 2024
6 checks passed
@mathause mathause deleted the test_min-all-deps branch February 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants