Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require regionmask >= 0.9 #399

Merged
merged 2 commits into from Feb 16, 2024

Conversation

mathause
Copy link
Member

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

Extracted requiring regionmask >= 0.9 from #398

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b0b76b) 87.90% compared to head (478238f) 87.95%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   87.90%   87.95%   +0.04%     
==========================================
  Files          40       40              
  Lines        1745     1743       -2     
==========================================
- Hits         1534     1533       -1     
+ Misses        211      210       -1     
Flag Coverage Δ
unittests 87.95% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@mathause
Copy link
Member Author

Thanks. Just for reference - support for regionmask 0.8 was broken as natural_earth_v5_0_0 is used (which is regionmask 0.9+)

land_110 = regionmask.defined_regions.natural_earth_v5_0_0.land_110

@mathause mathause merged commit 00cabf9 into MESMER-group:main Feb 16, 2024
6 checks passed
@mathause mathause deleted the require_regionmask_0.9 branch February 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants