Add tests for harmonic model #431
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 87.90% 83.65% -4.26%
==========================================
Files 40 44 +4
Lines 1745 1939 +194
==========================================
+ Hits 1534 1622 +88
- Misses 211 317 +106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
This reverts commit 40a1f45.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Okay this looks good, now for the last hurdle: how do we want to test numerical stability? I can just hard code some expected output into it or we can save output data somewhere. The thing is that for hard coding output it is rather nasty because it is notoriously hard (impossible?) to get pretty numbers, but for saving it it is rather little data to check... To see what I mean I push an example hard coded test below. |
for more information, see https://pre-commit.ci
Ah of course! We only need at least two different temperature values so that the system of equations is well defined. So I guess the easiest option would be to switch to that. |
for more information, see https://pre-commit.ci
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
|
Thanks @veni-vidi-vici-dormivi! |
* add tests for harmonic model * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * flaking * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * generalise tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add test for fit to bic xr, rearrange and remove order in generate fs * pandas datetime version compliance * Revert "pandas datetime version compliance" This reverts commit 40a1f45. * actual pandas datetime compliance * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make coefficients a numpy array * extend tests on generate fourier series * write out tolerance in test_fit_to_bic * write out max_order * use time.dt.month for months * fix for the nan and zero wrangling * verbose 0.1 in xr test * add tests for dataarray in xr func * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add test for numerical stability * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * test with non constant predictors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove comment about close residuals Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * add Note Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
No description provided.