Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer harmonic model order from coefficients #434

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

In the harmonic model generate_fourier_series we passed the order as an argument instead of inferring it from the length of the coefficients array. This is changed here. Additionally, I reordered the arguments to facilitate testing on xarrays.

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.94%. Comparing base (9b0b76b) to head (7094488).
Report is 30 commits behind head on main.

Files Patch % Lines
mesmer/mesmer_m/harmonic_model.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   87.90%   81.94%   -5.96%     
==========================================
  Files          40       44       +4     
  Lines        1745     1939     +194     
==========================================
+ Hits         1534     1589      +55     
- Misses        211      350     +139     
Flag Coverage Δ
unittests 81.94% <50.00%> (-5.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to rename the function and make it private but that can be another PR (#410).

Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi merged commit 10c8c43 into MESMER-group:main May 6, 2024
9 checks passed
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi deleted the hm_infer_order branch May 6, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants