New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: [Proposals] New get proposals index functions #427
Conversation
@cvandeplas Thanks! @iglocska Is there a way to do that without the URL parameters? |
Bug in _make_timestamp
Fix missing f in f-string
add: New attribute type weakness
Fix MISP#433 Few cleanups in code.
Turns out, if you modify a variable defined outside the __init__, every instances (and inherited classes) of that class will be impacted by it.
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
- Coverage 40.59% 40.56% -0.04%
==========================================
Files 34 34
Lines 5776 5784 +8
==========================================
+ Hits 2345 2346 +1
- Misses 3431 3438 +7
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
- Coverage 40.59% 38.25% -2.35%
==========================================
Files 34 35 +1
Lines 5776 6146 +370
==========================================
+ Hits 2345 2351 +6
- Misses 3431 3795 +364
Continue to review full report at Codecov.
|
As discussed, another commit covers this functionality, except the |
Right, The clean way here is probably to use |
This PR adds the functionality to get the proposals list.
It also supports the filter for the timestamp that was introduced in MISP 2.4.111, but also works (without time-filter) on older MISPs.