Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carrier mail functionality #38

Closed

Conversation

begunrom
Copy link
Contributor

Implements processing of a carrier mail that contains email attachments. Each email attachment is converted into an individual MISP event.

Implements processing of a carrier mail that contains email attachments. Each email attachment is converted into an individual MISP event.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 48

  • 6 of 20 (30.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.5%) to 63.043%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mail2misp/mail2misp.py 6 20 30.0%
Totals Coverage Status
Change from base Build 47: -2.5%
Covered Lines: 203
Relevant Lines: 322

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 48

  • 6 of 20 (30.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.5%) to 63.043%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mail2misp/mail2misp.py 6 20 30.0%
Totals Coverage Status
Change from base Build 47: -2.5%
Covered Lines: 203
Relevant Lines: 322

💛 - Coveralls

@codecov
Copy link

codecov bot commented Nov 16, 2019

Codecov Report

Merging #38 into master will decrease coverage by 2.53%.
The diff coverage is 30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   65.57%   63.04%   -2.54%     
==========================================
  Files           4        4              
  Lines         305      322      +17     
==========================================
+ Hits          200      203       +3     
- Misses        105      119      +14
Impacted Files Coverage Δ
mail2misp/mail2misp.py 61.73% <30%> (-2.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d747ede...b02cce7. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2019

This pull request introduces 1 alert when merging 26ef177 into d747ede - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@begunrom begunrom closed this Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants