Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: fix #85 #163 revise managing feeds and figs #225

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

chrisinmtown
Copy link
Contributor

@chrisinmtown chrisinmtown commented Feb 26, 2021

Update managing feeds so figures and text match MISP v2.4.137 features

Update managing feeds so figures and text match MISP v2.4.137 features
@chrisinmtown
Copy link
Contributor Author

chrisinmtown commented Feb 26, 2021

I would like to add reviewers here like @adulau and @Wachizungu but don't see a way to do that, am I blind today?

@Wachizungu
Copy link
Contributor

I'm guessing only the members of the project can do certain actions like adding reviewers.

I'm just a contributor myself so I also count on the reviews from core MISP team. They keep an eye on the projects / pull requests so they'll pick it up and review when they have some time don't worry. There's no need to specifically ping them.

As for my feedback:
To me it looks nice :D, happy to see the overlap analysis in there. Glad to see contribution from more people as well! I am not an active user of the feeds myself (yet) though so I'll not say more than that on this PR. I'm planning to have a look into feeds myself the next month so if I figure something extra out I'll probably add it on here as well.

@iglocska iglocska merged commit 8997e93 into MISP:main Feb 26, 2021
@iglocska
Copy link
Member

Awesome, thanks a lot, much clearer than what we had before!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants