Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAD Auth not working #34

Closed
thezolin opened this issue Mar 27, 2024 · 4 comments · Fixed by #39
Closed

AAD Auth not working #34

thezolin opened this issue Mar 27, 2024 · 4 comments · Fixed by #39
Assignees
@shieldsurge
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thezolin
Copy link

Hello,

I'm using CoolAcid container version on my production environment, and when I start the migration to this container, I've noticed the AAD authentication is not working or not supported anymore.

I have the put all settings on config.php file and add cake module to bootstrap.php file also.
@ostefano
Copy link
Collaborator

Ack 👍

Feel free to open a PR if you have enough spare cycles to work on it.

@ostefano ostefano added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 27, 2024
@thezolin
Copy link
Author

Hi ostefano,

After investigation This line on configs/config.php file ...

image

...was changed to this:
image

Any idea what this behavior occurs?

@ostefano
Copy link
Collaborator

Because this setting is getting overwritten by apply_critical_fixes which is executed before set_up_oidc and set_up_ldap. If you want to use a new authenticator like AAD you need to edit the core/files/configure_misp.sh, implement something similar in spirit to set_up_oidc or set_up_ldap and rebuild the image / create a pull request.

shieldsurge added a commit to shieldsurge/misp-docker that referenced this issue Apr 5, 2024
@shieldsurge
Add AadAuth support in configure_misp.sh
b31b830 
Add support for enabling Azure AD (aka Entra) authentication via the configure_misp.sh script. The function to enable Azure AD auth mirrors the code in the existing functions to enable OIDC and LDAP auth.

Environment variables are provided to configure available options in the AadAuth plugin:
https://github.com/MISP/MISP/tree/2.4/app/Plugin/AadAuth

This commit addresses issue "AAD Auth not working" MISP#34.
MISP#34
@shieldsurge shieldsurge mentioned this issue Apr 5, 2024
Merged
@shieldsurge
Copy link
Contributor

I had this same issue. Per @ostefano's suggestion, I implemented code similar to set_up_oidc and set_up_ldap within core/files/configure_misp.sh, and I created a pull request.
https://github.com/MISP/misp-docker/pull/39

@ostefano ostefano removed the help wanted Extra attention is needed label Apr 5, 2024
@ostefano ostefano linked a pull request Apr 10, 2024 that will close this issue
Add AadAuth support in configure_misp.sh #39
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shieldsurge shieldsurge

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add AadAuth support in configure_misp.sh shieldsurge/misp-docker
3 participants
@ostefano @thezolin @shieldsurge