Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of SSL redirection #21

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Allow disabling of SSL redirection #21

merged 1 commit into from
Mar 6, 2024

Conversation

ostefano
Copy link
Collaborator

@ostefano ostefano commented Mar 1, 2024

No description provided.

@gritty-Kitty
Copy link

gritty-Kitty commented Mar 4, 2024

Apologies for delay, and thank you in advance for your efforts. Updated docker-compose.yml with your changes, but trying to determine how to pull the noredirect build. Can you provide a hint on the convention of how to specify a specific build within the Docker-Compose.yml?

I have tried various sub-tags, and tried fudging the image location, but gave up after about an hour.

misp-core:
image: ghcr.io/misp/misp-docker/misp-core:latest

@kelke
Copy link
Contributor

kelke commented Mar 4, 2024

This is exactly what I needed. Hope this will get merged soon 👍🏼

@ostefano
Copy link
Collaborator Author

ostefano commented Mar 4, 2024

@gritty-Kitty , you need to build the image first, then just use the tag latest. Obviously you can test it only where you build it.

@kelke only after there is some testing, so any help is appreciated in that direction :)

@ostefano ostefano linked an issue Mar 4, 2024 that may be closed by this pull request
@gritty-Kitty
Copy link

Good afternoon,

I have attempted a build, but have stalled. Any insight on how to resolve is greatly appreciated.

Had to edit Dockerfile CORE_TAG=2.4 so it would resolve and compile.
https://raw.githubusercontent.com/MISP/MISP/2.4/app/composer.json
... but, then it appeared to choke at the end.


2024-03-04_10-52-13

infinity@ONHMISP0ZWF001:/misp-docker-noredirect/core$ sudo docker image prune
infinity@ONHMISP0ZWF001:
/misp-docker-noredirect/core$ sudo docker image ls
REPOSITORY TAG IMAGE ID CREATED SIZE
ghcr.io/misp/misp-docker/misp-modules latest d651cccc2691 4 days ago 1.15GB
ghcr.io/misp/misp-docker/misp-core latest 13645676ebeb 4 days ago 985MB
mariadb 10.11 161aacd369c1 11 days ago 404MB
redis 7.2 d1397258b209 7 weeks ago 138MB
portainer/portainer-ce latest 1a0fb356ea35 2 months ago 294MB
ixdotai/smtp latest 6fc2f5b2c12a 4 months ago 93.6MB
hello-world latest d2c94e258dcb 10 months ago 13.3kB

infinity@ONHMISP0ZWF001:~/misp-docker-noredirect/core$ sudo docker build -t misp-core .
https://raw.githubusercontent.com/MISP/MISP//app/composer.json -does not exist

@ostefano
Copy link
Collaborator Author

ostefano commented Mar 4, 2024

You need to create the .env file as per README before building the image.

@gritty-Kitty
Copy link

gritty-Kitty commented Mar 5, 2024

Good morning,

Our implementation is based on Ubuntu 22.04 LTS, Docker, and Portainer.

I appear to lack the knowledge and experience required to compile and test. I struggled with Docker at the command line with a .env file that did not appear to be recognized (same output as above).

https://stackoverflow.com/questions/47968875/how-to-build-docker-with-env-file

Then turned my focus towards building an Image in Portainer, but it also exhibited errors during the build process. There does not appear to be any mechanism that allows me to bind a .env file to the Portainer Image creation process.

2024-03-05_8-14-24

@ostefano
Copy link
Collaborator Author

ostefano commented Mar 5, 2024

The error you are seeing is because of an old version of docker (or docker-compose).

@gritty-Kitty
Copy link

gritty-Kitty commented Mar 5, 2024

Good afternoon,

The server is a new build (~2-weeks old) using Microsoft Azure Marketplace Ubuntu 22.04 LTS with all updates/upgrades applied weekly. The sole purpose of this server is to host MISP, but due to aging dependencies, we were forced to entertain a Docker-instance, and found your project. Docker was pulled using apt-get, and Portainer was pulled from Docker when installed. Posted here for your awareness.

sudo apt-get install docker-ce docker-ce-cli containerd.io docker-compose
sudo docker volume create portainer_data
sudo docker run -d -p 18000:8000 -p 9443:9443 -p 19000:9000 --name portainer --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer-ce:latest
sudo docker ps

Can't comment on age or freshness of Docker or Docker-Compose, other than this was a fresh installation.

My build efforts revolved around the DockerFile and creating a new Image so I could return to my Portainer Stack and attempt a redeployment, but could never get the build to work.

2024-03-05_10-49-25

Apologies in advance. I tried.

@ostefano ostefano merged commit 6f8dd83 into master Mar 6, 2024
1 check passed
@ostefano
Copy link
Collaborator Author

ostefano commented Mar 6, 2024

I've just merged it.

@kelke
Copy link
Contributor

kelke commented Mar 7, 2024

I did not find any bugs as well. Works just as expected

@ostefano ostefano deleted the noredirect branch May 3, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MISP - How Disable Redirect http to https
3 participants