Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile update #51

Closed
wants to merge 6 commits into from
Closed

Dockerfile update #51

wants to merge 6 commits into from

Conversation

challs
Copy link
Contributor

@challs challs commented Sep 5, 2019

Hi there

These changes reduce the complexity of the Dockerfile and number of interim images created. The functionality itself is unchanged so this should simply work for anyone who already has the images building properly.

@coolacid
Copy link
Contributor

coolacid commented Oct 17, 2019

Would you be willing to test with new bases?

  • ubuntu:bionic (to keep in line with current build)
  • debian:buster-slim (to slim down the size and only have base requirements)

@adulau
Copy link
Member

adulau commented Nov 20, 2019

Could you rebase to the current version of misp-docker to resolve the conflict? Thanks a lot.

To reduce the number of interim images
Removing more interim images
All the package installs are moved to the start of the process
* Merge multiple RUN commands together
* Generate the config files beforehand, then change permissions in one go
@challs
Copy link
Contributor Author

challs commented Nov 22, 2019

Could you rebase to the current version of misp-docker to resolve the conflict? Thanks a lot.

I've merged all the changes in and pushed to the branch.

(Note I'm not able to test a complete build yet because of the speed of my internet connection.)

@challs
Copy link
Contributor Author

challs commented Nov 22, 2019

Would you be willing to test with new bases?

  • ubuntu:bionic (to keep in line with current build)
  • debian:buster-slim (to slim down the size and only have base requirements)

I did some testing with Bionic and managed to get a build. You can find the changes I needed at challs@348b891

This module does not support the Python version on Xenial, so we do
not install it for now. This can be reenabled when the base image
is updated to a version with Python > 3.5.2
@challs
Copy link
Contributor Author

challs commented Nov 25, 2019

(Note I'm not able to test a complete build yet because of the speed of my internet connection.)

I've now checked the build. It turns out that misp-modules recently introduced a dependency on apiosintDS, but this is not available on Xenial so the build fails. The problem does not show up on current master because of #62.

I worked around the issue in eacda8f. The workaround can be removed by moving to a newer base image.

I confirm that this pull request also closes #62

@adulau
Copy link
Member

adulau commented Jan 9, 2020

Could you rebase with the current HEAD? and update the pull-request? Thanks a lot.

@challs
Copy link
Contributor Author

challs commented Jan 9, 2020

Could you rebase with the current HEAD? and update the pull-request? Thanks a lot.

Thanks for merging some of my changes. I will open separate PRs for the remaining items, since they are mostly unrelated to each other now.

@challs challs closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants