-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile update #51
Conversation
Would you be willing to test with new bases?
|
Could you rebase to the current version of misp-docker to resolve the conflict? Thanks a lot. |
To reduce the number of interim images
Removing more interim images
All the package installs are moved to the start of the process
* Merge multiple RUN commands together * Generate the config files beforehand, then change permissions in one go
a845cd8
to
e235bd7
Compare
I've merged all the changes in and pushed to the branch. (Note I'm not able to test a complete build yet because of the speed of my internet connection.) |
I did some testing with Bionic and managed to get a build. You can find the changes I needed at challs@348b891 |
This module does not support the Python version on Xenial, so we do not install it for now. This can be reenabled when the base image is updated to a version with Python > 3.5.2
I've now checked the build. It turns out that I worked around the issue in eacda8f. The workaround can be removed by moving to a newer base image. I confirm that this pull request also closes #62 |
Could you rebase with the current HEAD? and update the pull-request? Thanks a lot. |
Thanks for merging some of my changes. I will open separate PRs for the remaining items, since they are mostly unrelated to each other now. |
Hi there
These changes reduce the complexity of the Dockerfile and number of interim images created. The functionality itself is unchanged so this should simply work for anyone who already has the images building properly.