Check filename for invalid characters before saving e.g. "a:b.obj" #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without such a check writers might (and some do) create empty files that are not even named as expected (e.g. "a" instead of "a:b.obj"). The opening std::ofstream for such a filename does not seem to set any fail-bits (all checked for in the affected writer class). The alternative to a check here would be a check in each possible writer class. This seems worse. Signed-off-by: Daniel Maleike <daniel.maleike@stryker.com>
maleike
changed the title
kislinsk
requested changes
Sep 9, 2019
Signed-off-by: Daniel Maleike <daniel.maleike@stryker.com>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per default the Data Manager's "Save..." option via QmitkIOUtil proposes the DataNode's name as the filename. When the node name is "a:b" or simliar, this might produce files that are empty and named slightly different (in the example "a" instead of "a:b.obj"). The problem is that file systems do not accept all characters (esp. Windows)
Without a in QmitkIOUtil writers might (and some do) create empty files
that are not even named as expected (e.g. "a" instead of "a:b.obj").
The opening of a std::ofstream for such a filename does not seem to set
any fail-bits (all checked for in the affected writer class). So even writers that correctly check for the output stream state won't notice the problem.
The alternative to a check here would be a check in each possible writer class. This seems worse.
Signed-off-by: Daniel Maleike daniel.maleike@stryker.com