Do not include uic generated file in header #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QmitkLevelWindowWidget.h included ui_QmitkLevelWindowWidget.h. This is a file generated by QT's uic. And it is not right to include it in the header. An application that includes QmitkLevelWindowWidget.h fails to compile. A corect way is to do forward declaration in the header and include the generated header in corresponding cpp file. Please see the commit for more details, it is standard way to use uic generated headers, and is already used in many mitk headers already. Signed-off-by: Sukhraj Singh <sukhraj.singh01@stryker.com>
|
Thanks! Merged into develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QmitkLevelWindowWidget.h included ui_QmitkLevelWindowWidget.h. This is a file generated by QT's uic. And it is not right to include it in the header. An application that includes QmitkLevelWindowWidget.h fails to compile. A correct way is to do forward declaration in the header and include the generated header in the corresponding cpp file. Please see the commit for more details; it is a standard way to use uic generated headers, and is already used in many mitk headers already.
Signed-off-by: Sukhraj Singh sukhraj.singh01@stryker.com