Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include uic generated file in header #272

Closed
wants to merge 1 commit into from
Closed

Do not include uic generated file in header #272

wants to merge 1 commit into from

Commits on Aug 2, 2023

  1. Do not include uic generated file in header 

    QmitkLevelWindowWidget.h included ui_QmitkLevelWindowWidget.h. This is a file generated by QT's uic. And it is not right to include it in the header. An application that includes QmitkLevelWindowWidget.h fails to compile. A corect way is to do forward declaration in the header and include the generated header in corresponding cpp file. Please see the commit for more details, it is standard way to use uic generated headers, and is already used in many mitk headers already.

Signed-off-by: Sukhraj Singh <sukhraj.singh01@stryker.com>
    @sukhraj-singh-pro
    sukhraj-singh-pro committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a578ff5 View commit details
    Browse the repository at this point in the history