Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Commit

Permalink
tmp
Browse files Browse the repository at this point in the history
  • Loading branch information
JPrevost committed Mar 1, 2016
1 parent 8767a5e commit 21c9625
Showing 1 changed file with 3 additions and 12 deletions.
15 changes: 3 additions & 12 deletions app/controllers/callbacks_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ class CallbacksController < ApplicationController

def status
@submission = Submission.find_by_uuid(params[:uuid])
logger.debug("params: #{params}")
validate_submission_and_params(params)
initial_status = @submission.status
extract_and_update_status_and_handle(params)
Expand All @@ -17,26 +16,18 @@ def status
private

def extract_and_update_status_and_handle(params)
json = JSON.parse(params[:callback])
puts "JSON Status: #{json['status']}"
raise ActionController::RoutingError, 'Invalid Status' unless json['status']
@submission.status = json['status'] if valid_status?(json['status'])
extract_and_update_handle(json) if @submission.status == 'approved'
raise ActionController::RoutingError, 'Invalid Status' unless params[:status]
@submission.status = params[:status] if valid_status?(params[:status])
@submission.handle = params[:handle] if @submission.status == 'approved'
end

def validate_submission_and_params(params)
raise ActionController::RoutingError, 'Not Found' unless @submission
raise ActionController::RoutingError, 'Invalid Status' unless params[:callback]
end

def extract_and_update_handle(json)
handle = json['handle']
@submission.handle = handle
end

# move this to the model?
def valid_status?(status)
puts "status attempted: #{status}"
%w(approved rejected).include?(status)
end
end

0 comments on commit 21c9625

Please sign in to comment.