In 896 app stabilization #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonavellecuerdo
requested review from
ghukill and
ehanson8
and removed request for
ghukill
jonavellecuerdo
force-pushed
the
IN-896-app-stabilization
branch
from
369d4f6
to
266f084
Compare
Pull Request Test Coverage Report for Build 5895633125
💛 - Coveralls |
Why these changes are being introduced: * Keeping our Python version and dependencies updated is good practice and allows us to take advantage of the latest security updates and bug fixes for Python. How this addresses that need: * Update Dockerfile * Update Pipfile * Update .python-version Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-896
Why these changes are being introduced: * We updated our method for managing linters and code formatting for our Python projects to simplify configuration and use. How this addresses that need: * Apply standard pyproject.toml file * Deprecate setup.cfg * Apply linting with Ruff * Set black, mypy, ruff, and safety as linters * Add pre-commit hooks * Update Makefile * Update Pipfile Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-896
* Update imports, type hinting, and datetime calls in webhook modules * Update mypy command in Makefile * Update dependencies * Update _test_env fixture and datetime calls in conftest module * Update test_validate_missing_signature_returns_false with more explicit error check
ehanson8
force-pushed
the
IN-896-app-stabilization
branch
from
266f084
to
1cce502
Compare
ghukill
approved these changes
Aug 18, 2023
Comment on lines
+15
to
+35
| os.environ["AWS_ACCESS_KEY_ID"] = "testing" | ||
| os.environ["AWS_DEFAULT_REGION"] = "us-east-1" | ||
| os.environ["AWS_SECRET_ACCESS_KEY"] = "testing" | ||
| os.environ["AWS_SECURITY_TOKEN"] = "testing" | ||
| os.environ["AWS_SESSION_TOKEN"] = "testing" | ||
| os.environ["ALMA_CHALLENGE_SECRET"] = "itsasecret" | ||
| os.environ["ALMA_POD_EXPORT_JOB_NAME"] = "PPOD Export" | ||
| os.environ["ALMA_TIMDEX_EXPORT_JOB_NAME_PREFIX"] = "TIMDEX Export" | ||
| os.environ["ALMA_BURSAR_EXPORT_JOB_NAME_PREFIX"] = "Export to bursar" | ||
| os.environ["LAMBDA_FUNCTION_URL"] = "http://example.com/lambda" | ||
| os.environ[ | ||
| "PPOD_STATE_MACHINE_ARN" | ||
| ] = "arn:aws:states:us-east-1:account:stateMachine:ppod-test" | ||
| os.environ[ | ||
| "TIMDEX_STATE_MACHINE_ARN" | ||
| ] = "arn:aws:states:us-east-1:account:stateMachine:timdex-test" | ||
| os.environ[ | ||
| "BURSAR_STATE_MACHINE_ARN" | ||
| ] = "arn:aws:states:us-east-1:account:stateMachine:bursar-test" | ||
| os.environ["VALID_POD_EXPORT_DATE"] = "2022-05-23" | ||
| os.environ["WORKSPACE"] = "test" |
There was a problem hiding this comment.
Assuming this change was from ruff and I think it's okay as-is, but we might want to keep our eyes open for ways in which the testing environment is set across projects.
For one, the repeating os.environ[KEY] = VALUE could be performed in a loop from a list of key/value pairs. And that begs the question whether or not those key/value pairs should be defined in the fixture itself, or somewhere else (example you can define a pytest.ini file, or even the pyproject.toml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the alma-webhook-lambdas repository to use new Python version and dependencies, as well as the new linting and code formatting configurations for our Python projects.
Helpful background context
The main updates introduced in this PR are to:
How can a reviewer manually see the effects of these changes?
make install(Pipfile.lockhas been updated with fresh install of dependencies and therefore are updated)make lintmake testmake dist-dev(The command to build the Docker image with Python 3.11 runs successfully, but the application itself still needs to be tested.)Includes new or updated dependencies?
YES
What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/IN-896
Developer
Code Reviewer