Re-add CI yaml for Github actions and fix broken tests #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: The base Harvester class relies on a utility method convert_to_utc() to convert whatever datetime object is parsed from the CLI arguments to UTC time. In a deployed context (or Github actions) the "local" timezone is UTC, so this should have no effect. From a developer machine, this is likely EST or another timezone. Previously, the unit test had a 5 hour bump for the datetime assertion, which reflected the parsed UTC time. When in reality, the unit test should assert that a parsed YYYY-MM-DD date provided via the CLI matches a UTC time of that same format. How this addresses that need: * Unit test does not include hours or minutes but instead asserts same year, month, date equality and UTC timestamp Side effects of this change: * None Relevant ticket(s): * None
jonavellecuerdo
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Fixes a couple tests after fixture renaming, and re-adds
.github/ci.ymlto run automated Github actions tests.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)