Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Read response of swordTransfer #114

Closed
JPrevost opened this issue Mar 18, 2015 · 1 comment · Fixed by #229
Closed

Read response of swordTransfer #114

JPrevost opened this issue Mar 18, 2015 · 1 comment · Fixed by #229
Assignees
Milestone

Comments

@JPrevost
Copy link
Member

Currently we just assume sword transfer is successful.

We should handle:

  • timeouts
  • sword delivered successfully
  • sword rejected (and why) by reading response
@JPrevost
Copy link
Member Author

JPrevost commented Jun 1, 2015

It was pointed out in planning that we also need to figure out what to do with these errors we are handling (email Subscriber admins?, keep a log viewable by the Subscriber?, something else?)

@JPrevost JPrevost self-assigned this Jun 18, 2015
JPrevost added a commit that referenced this issue Jun 25, 2015
This handles both non-responses and non-success responses when
attempting a Sword transfer.

closes #114
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant