This repository has been archived by the owner on Oct 24, 2022. It is now read-only.
Read response of attempted Sword #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great: this is one we really needed to address, since I'm guessing this will be the most common hub failure. My only suggestion is to clean up the email template copy/paste stuff. The comment is from another template, and I think it should say 'deliver' rather than 'delivery'. Thanks a lot, 👍 |
|
Thanks. I'll fix that message and merge this morning. |
This handles both non-responses and non-success responses when attempting a Sword transfer. closes #114
JPrevost
force-pushed
the
114_confirm_sword_package_accepted
branch
from
0b9c5be
to
468319b
Compare
JPrevost
added a commit
that referenced
this pull request
Jun 25, 2015
…ccepted Read response of attempted Sword
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles both non-responses and non-success responses when
attempting a Sword transfer.
closes #114