Merge pull request #54 from MITLibraries/fix-recursion-bug

Fix recursion bug
MITLibraries · Mar 8, 2023 · b5d1b21 · b5d1b21
2 parents 3ab9bf6 + a875cfc
commit b5d1b21
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/transmogrifier/sources/transformer.py b/transmogrifier/sources/transformer.py
@@ -40,19 +40,20 @@ def __iter__(self) -> Iterator[TimdexRecord]:
 
     def __next__(self) -> TimdexRecord:
         """Return next transformed record."""
-        xml = next(self.input_records)
-        self.processed_record_count += 1
-        try:
-            record = self.transform(xml)
-        except DeletedRecord as error:
-            self.deleted_records.append(error.timdex_record_id)
-            return self.__next__()
-        if record:
-            self.transformed_record_count += 1
-            return record
-        else:
-            self.skipped_record_count += 1
-            return self.__next__()
+        while True:
+            xml = next(self.input_records)
+            self.processed_record_count += 1
+            try:
+                record = self.transform(xml)
+            except DeletedRecord as error:
+                self.deleted_records.append(error.timdex_record_id)
+                continue
+            if record:
+                self.transformed_record_count += 1
+                return record
+            else:
+                self.skipped_record_count += 1
+                continue
 
     @abstractmethod
     def get_optional_fields(self, xml: Tag) -> Optional[dict]: