TIMX-234 Update aspace identifiers logic #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehanson8
approved these changes
Aug 16, 2023
Why these changes are being introduced: It was discovered that some ASpace records after transformation contained multiple identifiers, of the same type, which was throwing errors in Bento. It looks as though ASpace records may have changed slightly and are exposing a new string for the <unitid> element, which is the same as the OAI record identifier. How this addresses that need: When iterating through <unitid> elements, by skipping those with attribute type=aspace_uri, we can skip adding that particular <unitid> as a TIMDEX record identifier. Side effects of this change: Believed to be none. Relevant ticket(s): https://mitlibraries.atlassian.net/browse/TIMX-234
ghukill
force-pushed
the
TIMX-234-update-aspace-identifiers
branch
from
8a93575
to
772feb8
Compare
Thanks, nice catch. Updated. |
ghukill
changed the title
ghukill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For ASpace records, any
<unitid type="aspace_uri">elements are skipped for consideration as TIMDEX recordidentifiers.Helpful background context
It was discovered that some ASpace records after transformation contained multiple identifiers, of the same type, which was throwing errors in Bento. It looks as though ASpace records may have changed slightly and are exposing a new string for the element, which is the same as the OAI record identifier.
Before:
After:
How can a reviewer manually see the effects of these changes?
Run the following transform:
identifiersproperty only has a single value, despite two<unitid>elements present under<archdesc level="collection">What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/TIMX-234
Developer
Code Reviewer
(not just this pull request message)
Includes new or updated dependencies?
YES