Merge pull request #102 from MITLibraries/TIMX-234-update-aspace-iden…

…tifiers

Why these changes are being introduced:

tests/fixtures/ead/ead_record_attribute_and_subfield_variations.xml

@@ -59,6 +59,9 @@
                         <unitid>
                             <emph>Data enclosed in subelement</emph>
                         </unitid>
+                        <unitid type="aspace_uri">
+                            <emph>unitid-that-should-not-be-identifier</emph>
+                        </unitid>
                         <abstract>
                             <emph>Data enclosed in subelement</emph>
                         </abstract>

tests/test_ead.py

@@ -526,6 +526,15 @@ def test_ead_record_invalid_date_and_date_range_are_omitted(caplog):
     ) in caplog.text
 
 
+def test_ead_record_correct_identifiers_from_multiple_unitid(caplog):
+    ead_xml_records = parse_xml_records(
+        "tests/fixtures/ead/ead_record_attribute_and_subfield_variations.xml"
+    )
+    output_record = next(Ead("aspace", ead_xml_records))
+    for identifier in output_record.identifiers:
+        assert identifier.value != "unitid-that-should-not-be-identifier"
+
+
 def test_ead_record_with_missing_optional_fields_transforms_correctly():
     ead_xml_records = parse_xml_records(
         "tests/fixtures/ead/ead_record_missing_optional_fields.xml"

transmogrifier/sources/ead.py

@@ -152,6 +152,8 @@ def get_optional_fields(self, xml: Tag) -> Optional[dict]:
         for id_element in collection_description_did.find_all(
             "unitid", recursive=False
         ):
+            if id_element.get("type") == "aspace_uri":
+                continue
             if id_value := self.create_string_from_mixed_value(
                 id_element,
                 " ",