Timx 270 date bug fix #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * Fixing date error reported by Sentry How this addresses that need: * Add date validation to create_dates_and_locations_from_publishers method * Add unit test and update Marc unit tests to drop invalid date values Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-270
ghukill
approved these changes
Apr 4, 2024
Comment on lines
+41
to
+48
| assert Transformer.create_dates_and_locations_from_publishers(fields) == { | ||
| "timdex_record_id": "abc123", | ||
| "publishers": [ | ||
| timdex.Publisher(name="Publisher", date="2018", location="Location") | ||
| ], | ||
| "dates": [timdex.Date(kind="Publication date", value="2018")], | ||
| "locations": [timdex.Location(value="Location", kind="Place of Publication")], | ||
| } |
There was a problem hiding this comment.
With this broken out into a method, nice and easy to test, I dig it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Bug fix based on this Sentry error
How can a reviewer manually see the effects of these changes?
Run the following command on the
mainbranch and observe the invaliddatesvalues from thepublishersfield inalma-transformed-records.json:Then run it on the
TIMX-270-date-bug-fixto observe that the invalid values no longer appear.Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)