Add methods to S3 class for selecting and archiving CSVs #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add methods to S3 class to select CSVs and archive the files after processing * Update deposit function with new methods and a bucket check at start * Remove doi_file_path from config.py and deposit.py * Update unit tests and fixtures to account for the updated code * https://mitlibraries.atlassian.net/browse/DLSPP-139
osmandin
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Helpful background context
The
test_deposit_s3_upload_failedCLI test was refactored intotest_deposit_s3_nonexistent_bucketgiven that access to the bucket should be determined at the start of the processHow can a reviewer manually see the effects of these changes?
Ensure the unit tests still pass with
pipenv run pytestWhat are the relevant tickets?
Requires Database Migrations?
NO
Includes new or updated dependencies?
NO