-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more Momentum options, mostly related to hFac #809
base: master
Are you sure you want to change the base?
Commits on Nov 7, 2023
-
New Coriolis option "selectCoriScheme = 4"
This switch allows to compute Coriolis terms, both horizontal (in 2.Omega.sin(Phi)) and NH (in 2.Omega.cos(Phi)), using the averaged transport (with face edge length and hFac factor), as done previously in V.I. for horizontal Coriolis.
Configuration menu - View commit details
-
Copy full SHA for 8aa64f4 - Browse repository at this point
Copy the full SHA 8aa64f4View commit details -
Change vertical advection for deepAtmosphere=T
For deep-model, absorb the NH-metric terms w.(u,v)/r into vertical advection by advecting the product "deepFac x (u,v)" (instead of just u,v).
Configuration menu - View commit details
-
Copy full SHA for 41c5588 - Browse repository at this point
Copy the full SHA 41c5588View commit details -
Configuration menu - View commit details
-
Copy full SHA for e865e99 - Browse repository at this point
Copy the full SHA e865e99View commit details
Commits on Nov 15, 2023
-
Adjust NH coriolis (new, selectCoriScheme=4) expression
- Add recip_hFacW/S (previously commented out) in new expression (selectCoriScheme=4) of NH coriolis f'*W term - remove hFacW/S from gW-Cori in selectCoriScheme=4 code and keep previous selectCoriScheme=4 code (with hFacW/S) under selectCoriScheme=6 block
Configuration menu - View commit details
-
Copy full SHA for 2954ba7 - Browse repository at this point
Copy the full SHA 2954ba7View commit details -
New Spherical Metric term expression
- New Spherical-Metric term form using grid-spacing finite differences (instead of analytical tan(Phi)/rSphere), supposed to improve both AM and KE conservation. Used (turned on) when selectVortScheme=1,2. - Add option to absorb the spherical-metric terms uMetricTerms = u.v.tanPhi/r into meridional advection by advecting the product "dxC x u" (instead of just u). Used (turned on) when selectVortScheme=2. Note: for now, re-cycle Flux-Form unused param "selectVortScheme" for this.
Configuration menu - View commit details
-
Copy full SHA for 3ce0348 - Browse repository at this point
Copy the full SHA 3ce0348View commit details
Commits on Nov 21, 2023
-
Adjust again gW-Cori just for the case selectCoriScheme=6
This option (selectCoriScheme=6, in mom_w_coriolis_nh.F) was left from early test, with hFacW/S multiplying uVel,vVel, but without scaling by any recip_hFac. The changes here fix this issue as the gW-Cori term is now divided by the grid-cell thickness at the wVel location (new argument recip_rThickC).
Configuration menu - View commit details
-
Copy full SHA for f8641c5 - Browse repository at this point
Copy the full SHA f8641c5View commit details -
Refine changes to vertical advection for deepAtmosphere=T
Two improvements: - single CPP option "MOM_USE_OLD_DEEP_VERT_ADV" in MOM_COMMON_OPTIONS.h to disable changes to vertical advection for deepAtmosphere=T - fix for the case useNHTerms=F with deepAtmosphere=T. Done by keeping a local copy of deepFacC in MOM_VISC.h, and adding 1 new argument to S/R mom_u_adv_wu.F, mom_v_adv_wv.F, mom_vi_{u,v}_vertshear.F
Configuration menu - View commit details
-
Copy full SHA for 658f29a - Browse repository at this point
Copy the full SHA 658f29aView commit details
Commits on Nov 29, 2023
-
Add new choice for vorticity advection, without r_hFacZ
This new option (with selectCortScheme=4) skip the division of vorticity by hFacZ and replace it with tendency scaling by recip_hFacW/S Also: - remove code related to "upwindVort3" (was hard-coded to FALSE) - add some missing "_d 0" ; + minor indentation changes
Configuration menu - View commit details
-
Copy full SHA for 1a91c9f - Browse repository at this point
Copy the full SHA 1a91c9fView commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d0b3dad - Browse repository at this point
Copy the full SHA d0b3dadView commit details
Commits on Feb 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e242cac - Browse repository at this point
Copy the full SHA e242cacView commit details
Commits on Feb 4, 2024
-
use new parameter "select3dCoriScheme"
no need to hack selectCoriScheme params and leave mom_vi_coriolis.F unchanged
Configuration menu - View commit details
-
Copy full SHA for ab357ce - Browse repository at this point
Copy the full SHA ab357ceView commit details -
use new parameter "selectMetricTerms"
- no need to hack selectVortScheme param - compute advection tendency in separated block if selectMetricTerms This makes sure results will not be affected (at trucation level) with current default metric-terms. - minor cleaning in mom_u/v_coriolis.F and mom_u/v_adv_wu/v.F
Configuration menu - View commit details
-
Copy full SHA for d7c5e1d - Browse repository at this point
Copy the full SHA d7c5e1dView commit details
Commits on Mar 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3577ffb - Browse repository at this point
Copy the full SHA 3577ffbView commit details
Commits on Apr 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 30961ae - Browse repository at this point
Copy the full SHA 30961aeView commit details
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for de5088e - Browse repository at this point
Copy the full SHA de5088eView commit details -
add diagnostics for Metric-Terms tendency
also rename 2 local variables (vF & v4F) more inline with other S/R and improve description
Configuration menu - View commit details
-
Copy full SHA for bd6a62e - Browse repository at this point
Copy the full SHA bd6a62eView commit details
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 439d116 - Browse repository at this point
Copy the full SHA 439d116View commit details
Commits on Jun 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 501d198 - Browse repository at this point
Copy the full SHA 501d198View commit details