Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement caching for the events.json files in the PublicWyscoutLoader #277

Closed
probberechts opened this issue May 3, 2022 · 0 comments
Closed

Implement caching for the events.json files in the PublicWyscoutLoader #277

probberechts opened this issue May 3, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@probberechts
Copy link
Member

In the public Wyscout dataset, all events of a season are stored in a single large JSON file. When loading data for a batch of games, this JSON file is parsed again for each game which makes loading data very slow. We should implement caching to make this faster.
@probberechts probberechts added the enhancement New feature or request label May 3, 2022
probberechts added a commit that referenced this issue Jul 9, 2022
@probberechts
[PublicWyscout] Implement caching for events.json
b5adcb1 
In the public Wyscout dataset, all events of a season are stored in a single large JSON file. When loading data for a batch of games, this JSON file is now parsed only once and the result is cached for loading successive game. This significantly speeds up the data loader for loading a large number of games from the same season.

Fixes #277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@probberechts