Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing fit and produce args as init params #102

Merged

Conversation

csala
Copy link
Contributor

@csala csala commented Aug 8, 2019

Resolve #96

Allow passing fit and predict arguments that will not change throughout the pipeline lifetime as init_params.

Also, in order to support and properly test this:

  • allow passing the primitive annotation dictionary directly to the MLPipeline instead of the primitive name
  • allow passing the primitive function (or class) directly within the annotation instead of passing the name to be imported.

@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #102 into master will increase coverage by 0.29%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   77.02%   77.31%   +0.29%     
==========================================
  Files           5        5              
  Lines         618      626       +8     
==========================================
+ Hits          476      484       +8     
  Misses        142      142
Impacted Files Coverage Δ
mlblocks/mlpipeline.py 85.46% <100%> (+0.64%) ⬆️
mlblocks/mlblock.py 91.3% <90%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1d483...c78c137. Read the comment docs.

@csala csala merged commit d5ba6e4 into master Aug 8, 2019
@csala csala deleted the issue-96-allow-passing-fit-and-produce-args-as-init_params branch August 8, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing fit and produce arguments as init_params
2 participants