Better support for saving to iOS home screen #393
Conversation
Make the site behave more like an app when saved to home screen Refs MLTSHP#392
static/50x.html
Outdated
| @@ -9,6 +9,9 @@ | |||
| <link type="text/css" rel="stylesheet" href="/static/css/main.css"> | |||
| <link type="text/css" rel="stylesheet" href="/static/css/account.css"> | |||
| <link rel="apple-touch-icon" href="/static/images/apple-touch-icon.png"> | |||
| <!-- Behave more like an app when saved to home screen in iOS --> | |||
There was a problem hiding this comment.
Does this actually accomplish anything on 500 pages? Seems like we only need this change for base.html
There was a problem hiding this comment.
It may only be needed for base.html, but I added it here for completeness. I suppose there's a possibility that you've saved the app to the home screen and you get a 500 next time you open it. In that case, it seems like these additions would apply.
There was a problem hiding this comment.
Adding this to any page that can potentially load instead of base.html makes sense to me.
Add space to try triggering the the CI
Revert previous change. Trying to trigger CI.
Hopefully this triggers CI
|
Is there any interest in this? It's a pain for me when browsing on mobile, but maybe I'm the only one. |
|
Whoops! Sorry for letting this sit idle for so long! @bradchoate: I don't have an easy way to test a pull request anymore, but what this commit does is tell iOS devices to treat the site like an app — it'll run in full-screen and have a black status bar. It'll also stop mobile safari from opening a new tab when launching from a shortcut, as outlined in #392. @iamthechad said:
This seems like an innocuous change to me. What do you think? Details here: https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html |
Make the site behave more like an app when saved to home screen
Refs #392