Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tumblr share button #613

Merged
merged 10 commits into from Jul 11, 2020
Merged

add tumblr share button #613

merged 10 commits into from Jul 11, 2020

Conversation

dieseltravis
Copy link
Member

@dieseltravis dieseltravis commented Jun 12, 2020

I am using a static HTML link instead of embedding their script/iframe for performance & privacy reasons

@dieseltravis dieseltravis self-assigned this Jun 12, 2020
@dieseltravis dieseltravis linked an issue Jun 12, 2020 that may be closed by this pull request
@dieseltravis dieseltravis marked this pull request as ready for review June 12, 2020 06:44
templates/image/show.html Outdated Show resolved Hide resolved
static/sass/areas/_permalink.scss Outdated Show resolved Hide resolved
static/sass/areas/_permalink.scss Outdated Show resolved Hide resolved
@dieseltravis
Copy link
Member Author

@bradchoate ok, take a look again when you get a chance, it should look like this now:
image

Thanks!

@bradchoate
Copy link
Collaborator

Not sure why, but the description and title values aren't populating into the post for me.

@dieseltravis
Copy link
Member Author

Not sure why, but the description and title values aren't populating into the post for me.

This is what I see on my end, for this URL: https://mltshp.com/p/1J0UC

The tumblr share link href should be:
https://tumblr.com/widgets/share/tool?canonicalUrl=https%3A%2F%2Fmltshp.com%2Fp%2F1J0UC&title=The+launch+of+Apollo+11%2C+July+16%2C+1969&content=https%3A%2F%2Fmltshp-cdn.com%2Fr%2F1J0UC&posttype=photo&caption=source%3A%20https%3A%2F%2Fi.redd.it&tags=mltshp

Which should open up in a pop-up like this:
image

Ah! I was just about to post this comment when I noticed the title wasn't included, and there is this in the documentation:

Title Used in Text, Link, and Chat post types data-title title

So, if I include the title in the Caption field instead, with couple line-breaks between the two and add asterisks to bold it in the markdown it will output like this:
image

Preview:
image

How does that sound?

@bradchoate bradchoate merged commit 060e99a into master Jul 11, 2020
@bradchoate bradchoate deleted the tumblr-patch-1 branch July 11, 2020 16:14
@macmanx2
Copy link
Contributor

Haha, yes, it works! 🎉 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tumblr Share Button
3 participants