Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any recommended decks other than the 3 on Readme? #21

Open
nezam7 opened this issue Apr 3, 2023 · 13 comments
Open

Any recommended decks other than the 3 on Readme? #21

nezam7 opened this issue Apr 3, 2023 · 13 comments

Comments

@nezam7
Copy link

nezam7 commented Apr 3, 2023

Not an issue. More like a discussion. Just want to know what decks you guys are using.
Any recommended standard deck?

Also.. maybe not be a bad idea if we can have a discord channel to discuss the deck, an improvement on the bot, etc.

Thanks for making this bot works. Helps a ton

@MOj0
Copy link
Owner

MOj0 commented Apr 3, 2023

Yo,
in general the all-in aggro decks should work the best, since that is the only thing the bot is doing 😄.

So, development of this bot is kind of stagnated. The thing is, to properly make such a bot, the best way is to read the memory of the game directly and do actions based of that, which I'm not doing (also that is easier to detect and ban). So since this bot is made in such a (primitive) way, it is very hard to build on top of it, if you get what I'm saying :)

I can make a simple discord server if you want and I can do simple bug fixes, but not huge improvements I'm afraid.

@nezam7
Copy link
Author

nezam7 commented Apr 28, 2023

i want to make a standard deck aggro. do u have any good deck for the bot? (standard)

@MOj0
Copy link
Owner

MOj0 commented Apr 28, 2023

Hi, well I put together this shurima aggro deck.
CMCQCAYGBYAQIBQNAECQMAIEAQDQGGRGGMDAEBQICQLC2MB4AAAQCAQGFA
It's not really amazing, perhaps I would need to add a separate logic just for that deck (just like with pirates and ephemeral decks).

@nezam7
Copy link
Author

nezam7 commented Apr 29, 2023

i mesh up some random aggro deck i found on mobalytics the other day but somehow the bot didnt run. i got back into ephemereal and pirate decks. will try this for sure. thanks

@MOj0
Copy link
Owner

MOj0 commented Apr 29, 2023

Yeah, when making a deck, you must take into account that bot doesn't know how to play all the cards. In general, it doesn't know how to do targeting, except for something like Oblivious Islander, which targets the cards in hand.
That being said, if you create a custom strategy (like pirates and ephemeral), you can code that logic in as well.

@nezam7
Copy link
Author

nezam7 commented Jun 9, 2023

image

managed to reached master with 100% bot. i use same modified aggro deck. i think at this point its probably nice to have a discord to talk about deck strategies like what are the optimum w/r with standard/wild deck etc.

@MOj0
Copy link
Owner

MOj0 commented Jun 9, 2023

Oh wow, I didn't think the bot would be this capable, to be honest. If you could share the deck code and your match history, so I can put it in the readme, that would be awesome :D
This is my discord username if you want to chat/talk: mojo7683

@nezam7
Copy link
Author

nezam7 commented Jun 9, 2023

i have added you. name nezam3035

@MOj0
Copy link
Owner

MOj0 commented Jun 9, 2023

I didn't get anything, and I also could not add you, says username is not found...

@nezam7
Copy link
Author

nezam7 commented Jun 10, 2023 via email

@MOj0
Copy link
Owner

MOj0 commented Jun 10, 2023

Right, but it should still work as my username is mojo7683...
Anyways I sent you a friend request and it went through.

@MOj0
Copy link
Owner

MOj0 commented Jun 10, 2023

Hi @LunaCasey, thanks for your feedback and the deck code, I'll update the readme with this.

Regarding a custom strategy, there is a Strategy class here . To add a custom strategy, you need to add another class, which extends Strategy class, like how it's done in Ephemeral for example. Then you need to add it to the DeckType enum here. Lastly, you need to add some logic, by which it will select that deck type here. If you have any trouble, comment here, or make a new Issue... perhaps I'll need to add this procedure to the readme aswell...

@ajdc2
Copy link

ajdc2 commented Jul 4, 2023

Has anyone had any success with the bot since the new expansion ? Now that ranked is standard the kalista deck seems gone and pirates lost some good cards. I have spent the past weeks messing around with pirates trying to find replacements but my best attempts don't exceed like 20% winrate. Has anyone had more luck ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants