Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure both CI and develoment environments don't include conda MPI #902

Merged
merged 2 commits into from
Sep 25, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 25, 2022

We build the package on HPC using the CI recipe, so it is better if it doesn't use conda's MPI. In addition, we don't want development environments to include MPI because the conda MPI package typically don't work on HPC, where we do a lot of our development and testing.

Finally, this merge also removes some unnecessary srun calls to mpas_analysis in the test suite. On many systems, nesting calls to srun within a parallel job doesn't work, and given that we may want to call ESMF_RegridWeightGen or ncclimo with srun within MPAS-Analysis, it would be better if we don't also call mpas_analysis unnecessarily with srun.

@xylar
Copy link
Collaborator Author

xylar commented Sep 25, 2022

Testing

Most of the test suite passed. The main vs. control run failed because of #901. See:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/anvil/fix_conda_mpi_on_hpc/

@xylar xylar merged commit 43d0544 into MPAS-Dev:develop Sep 25, 2022
@xylar xylar deleted the fix_conda_mpi_on_hpc branch September 25, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant