Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sea ice production/melting analysis tasks #907

Merged
merged 19 commits into from
Oct 10, 2022

Conversation

darincomeau
Copy link
Contributor

@darincomeau darincomeau commented Sep 27, 2022

Adds analysis task for climatology maps of sea ice total production and freezing, with comparisons to observations based on Haumann et al 2016. Note observations are only available for annual climatology, Southern Hemisphere.

closes #216

@darincomeau
Copy link
Contributor Author

I haven't gotten the observations to plot yet, but here's what I have so far in terms of production/melting plots:

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.dcomeau/20220901.DTESTM.T62_EC30to60E2r2.QCtest.anvil/yrs1-5/sea_ice/index.html

That directory will probably be wiped on my next run that errors out, so I'll post some plots here:
imageimage

@darincomeau
Copy link
Contributor Author

FYI @xylar the obs data is now getting remapped, and the error I'm seeing is at the stage of plotting the remapped obs data, so I think we're almost there (thanks for the help today!).

@xylar
Copy link
Collaborator

xylar commented Sep 28, 2022

@darincomeau
Copy link
Contributor Author

I ran this on a real run, and tweaked some of the plotting config options as a result:

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.dcomeau/20220808.v2.cryo.Bcase.submesoscale.ne30pg2_SOwISC12to60E2r4.chrysalis/yrs91-100/sea_ice/index.html

I'll talk briefly about this at tomorrow's check-in, but I think this is pretty much ready for review.

@darincomeau
Copy link
Contributor Author

Closes #216

@xylar
Copy link
Collaborator

xylar commented Sep 29, 2022

Closes #216

@darincomeau, this needs to go in the description, not a comment. I'll take care of it.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome and I'm excited to have it!

My one suggestion would be to go ahead and put everything in the same gallery, rather than having one with obs and one without. It's a little clunky either way since the thumbnails are different sizes but it makes comparing between seasons and annual a little bit easier:

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/sea_ice_prod_melt/v2.cryo.Bcase.submesoscale.ne30pg2_SOwISC12to60E2r4.chrysalis/clim_0001-0020_ts_0001-0020/sea_ice/index.html

I had mentioned that the filenames for the remapped observations looked weird to me. That's nothing you did -- MPAS-Analysis just gives remapped obs weird filenames, I guess. They contain both the original and the remapped grid resolutions, which was a surprise to me. Anyway, nothing we need to do anything about here.

mpas_analysis/sea_ice/climatology_map_melting.py Outdated Show resolved Hide resolved
mpas_analysis/sea_ice/climatology_map_production.py Outdated Show resolved Hide resolved
@xylar
Copy link
Collaborator

xylar commented Sep 29, 2022

@akturner and @milenaveneziani, please have a look when you can. It would be great to get this in!

@darincomeau
Copy link
Contributor Author

@xylar good suggestion, I've implemented it. I've also made the observations name change to AnIceFlux. Output now:

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.dcomeau/20220808.v2.cryo.Bcase.submesoscale.ne30pg2_SOwISC12to60E2r4.chrysalis/yrs91-100/sea_ice/index.html

One other thing I meant to solicit opinion on is whether this belongs in polar_regions.cfg. Now it's part of the regular output - I'll leave it there unless there's a stated preference to move it to polar_regions.

@xylar
Copy link
Collaborator

xylar commented Sep 29, 2022

One other thing I meant to solicit opinion on is whether this belongs in polar_regions.cfg. Now it's part of the regular output - I'll leave it there unless there's a stated preference to move it to polar_regions.

I think this should be on regardless. I think WC would be interested in it, not just cryosphere.

@milenaveneziani
Copy link
Collaborator

This looks great!
One only visual suggestion from me: could you please revert the colorer colors for the the Sea Ice Production bias in the SH? (blue for negative bias and red for positive bias)

@darincomeau
Copy link
Contributor Author

Thanks @milenaveneziani ! I've reverted that change per your suggestion, and reran my test analysis linked above to reflect that.

Copy link
Collaborator

@milenaveneziani milenaveneziani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Darin! this is good to go from my side.

@xylar
Copy link
Collaborator

xylar commented Oct 6, 2022

@akturner, just a reminder that we're waiting on your review of this one.

@xylar xylar removed the request for review from akturner October 10, 2022 01:50
@xylar
Copy link
Collaborator

xylar commented Oct 10, 2022

I'm taking @akturner off this for now. Seems like 2 reviews is probably enough.

@xylar xylar merged commit d23e07e into MPAS-Dev:develop Oct 10, 2022
@xylar xylar deleted the add_seaice_production_tasks branch October 10, 2022 01:50
@xylar
Copy link
Collaborator

xylar commented Oct 10, 2022

@darincomeau, thanks for the hard work on this!

@xylar
Copy link
Collaborator

xylar commented Oct 10, 2022

@darincomeau, one thing I forgot is that it would be great to have 4 new files added to the docs. You can see this one as an example. They're kind of formulaic but not so much so that I feel confident in writing yours.

https://github.com/MPAS-Dev/MPAS-Analysis/blob/develop/docs/users_guide/tasks/climatologyMapSeaIceConcNH.rst

@xylar
Copy link
Collaborator

xylar commented Oct 10, 2022

Obviously, since I merged this, it'll need to be its own PR.

@darincomeau
Copy link
Contributor Author

@xylar - sure, I'll put together those docs and open a PR.

Also, this PR's functionality is broken on develop. @cbegeman has the fix in dd29f0c (thanks for catching that!).

I tracked it down to the time gap between when I created this branch off develop and when #913 was merged a day later. I suppose I should have rebased, which would have caught this.

Anyways, happy to leave the fix in #917, or if it makes sense to do in the doc PR, can do that as well.

@xylar
Copy link
Collaborator

xylar commented Oct 11, 2022

@darincomeau, I saw this too late but I think it's fine that the fix goes in in @cbegeman's PR even though it's unrelated. And sorry for missing that in my testing, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add analysis of sea ice formation and melt rates
3 participants