Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config file on the webpage #913

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 28, 2022

The name of the complete config file should now be correct, so that the link works.

The control and main config files are also included if they are supplied.

closes #911

@xylar xylar added the bug label Sep 28, 2022
@xylar xylar self-assigned this Sep 28, 2022
@xylar xylar force-pushed the fix_config_provenance branch 3 times, most recently from ba1caff to de38b6e Compare September 28, 2022 22:54
The name of the complete config file should now be correct, so
that the link works.

The control and main config files are also included if they are
supplied.

Set the webportal username for the main and control config file
@xylar xylar removed the request for review from anirban89 September 28, 2022 23:07
@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2022

Testing

I tested this branch and #898 to produce these results:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/bsf_main_vs_ctrl/main/clim_0001-0020_ts_0001-0020/

All 4 config files (main vs. ctrl, main, ctrl and complete) are there and links work. I put back ${webportal:username} extended interpolation in the config file and it works now even in the main and ctrl config files.

@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2022

@anirban89, I had put you as a reviewer but I think my testing is sufficient. I'll just merge once the continuous integration (CI) tests from Azure finish, which should be soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mache config file not being included along with main or control config
1 participant