Bug fixes to enable aerosols & dust in multi-layer snow with Snicar-ad #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Snow surface layer thickness now properly defined for multiple snow layers. -Added a length scale and code for spreading surface atmospheric fluxes into the snow interior. High concentrations, for very thin snow layers and thick sea ice, will cause the snicar-ad code to crash. -Added a minimum snow thickness condition for atm-aerosol fluxes into the snow. BC and dust now enter the sea ice directly for very thin snow thicknesses. -corrected aerosol units mg/m3 to kg/m3 -diagnostic verticalSnowAerosolCell now defined
Enabled multiple snow layers and snicar-ad in aerosol test cleaned up ice_shortwave error messages and typpos
|
This code is BFB in the WC configuration. All five testsuites performed and passed except the standard_bgc and the aerosol_shortwave regression tests. This is expected because the PR has changes to the aerosol transport and snow grid are aerosols are enabled in the standard_bgc test. |
|
@njeffery "This code is BFB in the WC configuration": Does this mean you've run a B-case with this? Was it BFB for a full annual cycle? |
|
Hi Andrew,
The code changes are BFB in WC because the aerosols are off by default and there's no plans to use them for this phase. We're not sure yet if we want them on for BGC either. That would be a separate PR.
I have done a couple of 38-year fully coupled runs to test the feature. I added some results to the feature page: https://acme-climate.atlassian.net/wiki/spaces/DOC/pages/1907818531/B12+Activate+Aerosol+Shortwave+Feedbacks+in+Sea+Ice
The code base was a pre-v2 configuration from November that Jon had been testing. I'll do another simulation once we are closer to having a CBGCv2 code-base. then we can discuss whether it makes sense to activate.
Thanks for looking at this.
Nicole
…________________________________
From: Andrew Roberts <notifications@github.com>
Sent: Sunday, March 7, 2021 10:43:25 PM
To: MPAS-Dev/MPAS-Model
Cc: Jeffery, Nicole; Mention
Subject: [EXTERNAL] Re: [MPAS-Dev/MPAS-Model] Bug fixes to enable aerosols & dust in multi-layer snow with Snicar-ad (#818)
@njeffery<https://github.com/njeffery> "This code is BFB in the WC configuration": Does this mean you've run a B-case with this? Was it BFB for a full annual cycle?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#818 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB6UV2VAPSVFBAKNY43CECDTCRPX3ANCNFSM4YDEEA3A>.
|
proteanplanet
approved these changes
Mar 9, 2021
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Mar 15, 2021
Update mpas-source: Allows for sea ice radiative transfer calculations Brings in a new mpas-source submodule with changes ony to the seaice core. It allows for sea ice radiative transfer calculations of aerosols and dust. Merges MPAS-Dev/MPAS-Model#818 [Non-BFB] for aerosol/BGC sims
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Mar 16, 2021
Update mpas-source: Allows for sea ice radiative transfer calculations Brings in a new mpas-source submodule with changes ony to the seaice core. It allows for sea ice radiative transfer calculations of aerosols and dust. Merges MPAS-Dev/MPAS-Model#818 [Non-BFB] for aerosol/BGC sims
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for radiative transfer calculations of aerosols and dust in seaice. The capability will currently remain off as default.