Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In write_netcdf, make Time an unlimited dimension #382

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Dec 23, 2020

Otherwise, MPAS-Model seems to have trouble reading these files.

Otherwise, MPAS-Model seems to have trouble reading these files.
@xylar
Copy link
Collaborator Author

xylar commented Dec 23, 2020

Testing

I have used this in my COMPASS 1.0 prtotype (MPAS-Dev/compass#28) and with this change the files I write out with write_netcdf have Time as an unlimited dimension, whereas they were not before. When these files are read into MPAS-Model the memory footprint is substantially reduced compared with the version without the unlimited dimension (which crashes my laptop after using the full memory).

I also tested the QU240 test cases in the current COMPASS ocean nightly test suite. The culled mesh is created using write_netcdf, and it shows an unlimited time dimension (of length 0). The tests all ran successfully.

@xylar xylar merged commit c687ccb into MPAS-Dev:master Dec 24, 2020
@xylar xylar deleted the write_netcdf_Time_unlimited branch December 24, 2020 00:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant