Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files_for_e3sm step for remapping rms tidal velocity #770

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Feb 8, 2024

This field is needed for any meshes that will run in the TMIX configuration described here:
E3SM-Ocean-Discussion/E3SM#76
The field gets remapped from a dataset that @irenavankova has preprocessed from the CATS tidal model,
see https://web.lcrc.anl.gov/public/e3sm/mpas_standalonedata/mpas-ocean/tidal_mixing/README.txt.

Checklist

  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean labels Feb 8, 2024
@xylar xylar self-assigned this Feb 8, 2024
@xylar
Copy link
Collaborator Author

xylar commented Feb 8, 2024

Testing

I ran the files_for_e3sm test case (the one for pre-existing meshes) and pointed it to the IcoswISC30E3r5 mesh.

I was able to generate the RMS tidal velocity:
xylar

My version differs only slightly from @irenavankova's:
irena

The places where they differ are where there is very little overlap between the original grid and the MPAS mesh:
mask
and results from a different approach to renormalization when there is less than 10% overlap between the meshes.

@xylar
Copy link
Collaborator Author

xylar commented Feb 8, 2024

@irenavankova, this is ready for you to try out and review.

We should talk about the renormalization strategy. What I chose to do was to renormalize if there is more than 1% overlap and to set the velocity to zero if there is less.

It seemed like you had a different approach to cells with less than 10% overlap where you always renormalized as if the overlap were 1%. I think my approach is a little more standard and should lead to smoother results but I don't think it matters much because only a handful of cells are affected.

@xylar
Copy link
Collaborator Author

xylar commented Feb 8, 2024

@irenavankova, I sent you an invitation to collaborate here. If you accept, I can add you as a reviewer but you can still comment without being an official reviewer.

@xylar xylar changed the title Add files_for_e3sm step for remapping rms tidal vel Add files_for_e3sm step for remapping rms tidal velocity Feb 14, 2024
Copy link
Collaborator

@irenavankova irenavankova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works for me

@xylar
Copy link
Collaborator Author

xylar commented Feb 21, 2024

@irenavankova, thanks for testing this out!

@xylar xylar merged commit beb4cf7 into MPAS-Dev:main Feb 21, 2024
4 checks passed
@xylar xylar deleted the add-tidal-mixing-remap-step branch February 21, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants