Add util for culling MPAS-Ocean and -Seaice restart files #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
added
ocean
in progress
TestingI ran this in: using the following restart files: |
xylar
force-pushed
the
cull-restarts-in-files-for-e3sm
branch
from
9647f27
to
08589d6
Compare
cbegeman
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
I didn't run this myself, but the code changes and the restart files you linked to look good by visual inspection. I am comfortable with you merging this when you like and we can push fixes if any issues are revealed in the upcoming IcosX runs. Thanks for your work on this!
|
@cbegeman, I agree. Let's get this merged and we can tweak if necessary. |
xylar
force-pushed
the
cull-restarts-in-files-for-e3sm
branch
from
d2eb7f0
to
3b8952d
Compare
|
@cbegeman thanks so much for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a new version of MPAS-Tools (not yet released) with MPAS-Dev/MPAS-Tools#557
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes