-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add area integrated annual mean to data iceberg and ice-shelf flux files #836
base: main
Are you sure you want to change the base?
Conversation
@cbegeman, this is part of the design https://acme-climate.atlassian.net/wiki/spaces/PSC/pages/4210098268/Design+Document+Data+iceberg+and+ice-shelf+melt+flux+patterns+for+E3SM+spin-up+runs. Do you want to take a quick look at this, particularly the In the meantime, i'll run this through the IcoswISC240 workflow to see what I get. |
5252ae1
to
6444cb3
Compare
TestingI ran the IcoswISC240 workflow through I also have the test print out the total fluxes before and after normalization:
(Interesting to see that the calving flux is higher than the melt flux. I didn't remember that being the case in observations.) |
6444cb3
to
dc90cf2
Compare
@xylar I think this looks correct. I'm just wondering whether we will run into underflow issues on a grid-cell basis since I think we are dividing a flux with units kg m^-2 s^-1 by the total flux over 1 year and the whole domain. Have you looked at this? I could also be misunderstanding your approach. |
I don't anticipate underflow issues but I also don't really know how we might avoid them. Do you have a suggestion? |
@cbegeman, thinking about this a bit further, one solution that would likely avoid the underflow issue (if there is one) would be simply to precompute and store
I will probably switch to that approach but want to see what you think first. |
@xylar I like that solution. |
Testing with the new approachI reran
so things look good here, but we'll have to verify this in MPAS-Ocean and -Seaice. I also verified that I see the new fields in the NetCDF output files:
For the DIB file, we have to have 12 redundant copies along the
|
@xylar I think this looks great. Thanks! Let me know if you want me to do any testing. |
@cbegeman, I think this branch is probably in good shape and you don't need to test. Next steps would be to make new Icos DIB and DISMF files with this branch, and then to use those in testing the capability in E3SM. But that's a little way off still. |
175abc6
to
4eb269d
Compare
This is needed for an Antarctic balance approach in which all Antarctic solid runoff is converted into iceberg and ice-shelf melt with the patterns from the Merino et al. (2020) and Paolo et al. (2023) datasets.
Instead of normalizing the fluxes, simply add the totals as a new field to each file so they can be normalized later in code.
4eb269d
to
8b35df7
Compare
This appears to be working as expected in my E3SM branch in E3SM-Ocean-Discussion/E3SM#109. I am almost a year into a test with scaling enabled: |
This is needed for an Antarctic balance approach in which all Antarctic solid runoff is converted into iceberg and ice-shelf melt with the patterns from the Merino et al. (2020) and Paolo et al. (2023) datasets.
Checklist
api.rst
) has any new or modified class, method and/or functions listedTesting
in this PR) any testing that was used to verify the changes