Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes are not displaying correctly since Bootstrap v3.2 #103

Closed
michael-wolfenden opened this issue Nov 16, 2014 · 1 comment
Closed

Comments

@michael-wolfenden
Copy link

ChameleonForms is generating the following output for checkboxes:

<div class="checkbox">
    <input id="TermsAndConditions" name="TermsAndConditions" type="checkbox" value="true"> 
    <label for="TermsAndConditions">Terms and conditions</label>
    <em class="required" title="Required"></em>
</div>

However according to the Bootstrap documentation the markup should be:

<div class="checkbox">
    <label>
        <input id="TermsAndConditions" name="TermsAndConditions" type="checkbox" value="true" /> 
        Terms and conditions
    </label>
    <em class="required" title="Required">&lowast;</em>
</div>

The current markup causes the checkbox to be out of alignment as seen in this JSBin

Happy to submit a pull request to fix, however wasn't sure how you guys wanted to handle backwards compatibility for earlier versions of boostrap (although I did a quick check and the new html seems to display correctly back to v3.0.0)

@robdmoore
Copy link
Member

Nice pick up.

Yep - send through a PR. Maybe update the NuSpec to indicate a later version of bootstrap too.

On 16 Nov 2014, at 7:01 pm, Michael Wolfenden notifications@github.com wrote:

ChameleonForms is generating the following output for checkboxes:

Terms and conditions

However according to the Bootstrap documentation the markup should be:

Terms and conditions

The current markup causes the checkbox to be out of alignment as seen in this JSBin

Happy to submit a pull request to fix, however wasn't sure how you guys wanted to handle backwards compatibility for earlier versions of boostrap (although I did a quick check and the new html seems to display correctly back to v3.0.0)


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants