Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartialFor implementation #113

Closed
wants to merge 1 commit into from
Closed

Conversation

zabulus
Copy link
Contributor

@zabulus zabulus commented Jan 6, 2015

I've made all refactoring I wanted.
Breaking change I've mentioned it is extracting ISection interface from Section class.
I've made it because needed to reimplement Section extension methods in PartialProxySection. Now it need only to implement ISection interface, all extension methods we'll be added.

Fixed ViewData to be more strongly typed, though some reflection is used for this.

PS Sorry for the mess of PRs.

@zabulus
Copy link
Contributor Author

zabulus commented Apr 11, 2015

I've found several bugs in my implementation.

  1. Looks like binding from partial views doesn't work at all if PartialFor used. For now I'm sure that calling EditorFor for is not sufficient to work.
  2. BeginSection in child partial works wrong if use Form.PartialFor, Looks like it writes to another TextWriter.

@zabulus zabulus force-pushed the PartialFor3 branch 2 times, most recently from 4cd8941 to b6d42b7 Compare April 13, 2015 15:55
@zabulus
Copy link
Contributor Author

zabulus commented Apr 13, 2015

Fixing the HtmlHelper in ProxyForm looks like fixes issue number 2.
Though can't write test for all this issues.

@robdmoore robdmoore changed the title Partial for #3 PartialFor implementation Oct 3, 2015
@robdmoore
Copy link
Member

#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants