DICOM: Fix slice timing import for mosaic data #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong member function of class File::DICOM::CSAEntry was being used to pre-allocate the memory required to store slice timing, resulting in a mismatch in length between this data vector and the number of slices in the image. Closes #1252.
|
Note: This only affects the ability of MRtrix3 to create the key-value entry " |
|
Thanks for looking into it! Should definitely go to master once tested by Donald. It's making a lot of people panic / worry. |
|
OK, just put this through its paces on my DICOM test suite, it's all good! |
jdtournier
approved these changes
Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong member function of class
File::DICOM::CSAEntrywas being used to pre-allocate the memory required to store slice timing, resulting in a mismatch in length between this data vector and the number of slices in the image.For the sake of web searches, the issue that this fix corrects looks something like:
Closes #1252.
Should probably wait for @jdtournier to run against private DICOM test suite.