-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrtrix3.image.statistic(): Fix parameter naming #1504
Conversation
app.error() call contained a reference to the function being invoked, rather than the parameter that was passed to the function.
Same issue here as on #1505, but with added goodness:
Given that this is all based on In any case, I'll try to fix this one too. |
I note a stack of errors in the TravisCI logs at the |
OK, this looks like it works... @Lestropie: please review these changes and make sure you're happy. There's changes to your GIF algorithm, and to the |
On cursory inspection perhaps the new
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looks like this is fixed then!
app.error()
call contained a reference to the function being invoked, rather than the parameter that was passed to the function.Not hugely consequential given the script is throwing an error at that point anyway; but nevertheless preferable for a more appropriate error message than "
TypeError: must be str, not function
".Observed on forum.