-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix healthbar HUD #981
Fix healthbar HUD #981
Conversation
5a3a8ba
to
7bc9a0f
Compare
Shall I close in favor of an engine fix as discussed in Discord? |
If the engine gets a feature PR that allows implementing this slightly neater and the PR is merged, I will redo this. |
Last commit closes #986 by right-aligning the hearts. |
Note that this legitimizes duplicating the HUD bar def, as it requires repositioning the health bar. |
@savilli Bump. I see no reason not to merge this. This fixes two bugs. Implementing a builtin feature would be significantly more work (especially if inclusion in the engine is desired). This is now very clean and duplicates very little code (negligible). Pretty much everything that overrides the builtin defs has to duplicate just as much (small parts of the HUD element def). The only minor dirty thing I see is the use of the undocumented |
LGTM |
@LoneWolfHT please review |
Closes #979, closes #986